You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/10/28 20:54:11 UTC

[GitHub] [cordova-android] PieterVanPoyer opened a new pull request #1113: WIP: Features/webp support for splashscreen

PieterVanPoyer opened a new pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113


   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   Android
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   - Fixes https://github.com/apache/cordova-plugin-splashscreen/issues/257
   
   A splashscreen image on Android can be in a webp format. ( https://developer.android.com/studio/write/convert-webp )
   When a webp image is included the build breaks.
   
   ### Description
   <!-- Describe your changes in detail -->
   
   I did check the extension of the asset in code. If it's webp, than it is saved as webp.
   Else it is saved as a png.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   WIP: I have to do some extra testing.
   
   ### Todo
   Maybe something must be added in the documentation.
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [ ] I've updated the documentation if necessary
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu commented on a change in pull request #1113: WIP: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#discussion_r514296756



##########
File path: bin/templates/cordova/lib/prepare.js
##########
@@ -336,15 +336,27 @@ function updateSplashes (cordovaProject, platformResourcesDir) {
         if (resource.density === 'mdpi') {
             hadMdpi = true;
         }
-        var targetPath = getImageResourcePath(
-            platformResourcesDir, 'drawable', resource.density, 'screen.png', path.basename(resource.src));
+        var targetPath;

Review comment:
       ```suggestion
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer commented on a change in pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on a change in pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#discussion_r541957234



##########
File path: bin/templates/cordova/lib/prepare.js
##########
@@ -317,28 +318,13 @@ function getAdaptiveImageResourcePath (resourcesDir, type, density, name, source
     return resourcePath;
 }
 
-/**
- * The splashScreenSrc is a .webp image or a .png (or .jpg) image.
- * An inputted .webp should be copied to a screen.webp file.
- * An inputted .png (or .jpg) should be copied to a screen.png file.
- *
- * When a splashscreen is changed from a .png to a .webp or the other way round,
- * the other image must be deleted, to avoid a duplicate resource exception.
- *
- * @param splashScreenSrc
- * @returns {{splashScreenDestToRemove: string, splashScreenDest: string}}
- */
-function buildSplashScreenImageToCopyAndToRemove (splashScreenSrc) {
-    if (path.extname(splashScreenSrc) === '.webp') {
-        return {
-            splashScreenDest: 'screen.webp',
-            splashScreenDestToRemove: 'screen.png'
-        };
-    }
-    return {
-        splashScreenDest: 'screen.png',
-        splashScreenDestToRemove: 'screen.webp'
-    };
+function makeSplashCleanupMap (projectRoot, resourcesDir) {
+    // Build an initial resource map that deletes all existing splash screens
+    const existingSplashPaths = glob.sync(

Review comment:
       Seems like a forward and backwards slash problem in my tests. The resourcesDir is with backward slashes, but should be with forward slashes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer commented on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-747281016


   @breautek thanks for the effort. Maybe I should make an issue in the Cordova Docs repo, to add some info about the webp - support to the docs?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer commented on pull request #1113: WIP: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-719020804


   > Could you also test if .jpg splashscreen do work? It's stated in the docs, but it seems like that there is a hardcoded check to `screen.png`.
   
   @timbru31 Hey I did test the .jpg flow. Really odd, but it works. So what happens, the .jpg is saved as a screen.png in the android project. But android is just displaying it nice. 
   
   A testrepo is available at: https://github.com/PieterVanPoyer/cordova-plugin-splashscreen-testing-app/tree/testing/jpg-splash-screen 
   
   ![image](https://user-images.githubusercontent.com/33040889/97631956-15b80300-1a32-11eb-86f9-cba2bb6c7668.png)
   
   Now this pull is still WIP, because the original screen.png's (of the android template project must be deleted when webp is found. Still figuring out were to delete them.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer commented on a change in pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on a change in pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#discussion_r541959425



##########
File path: bin/templates/cordova/lib/prepare.js
##########
@@ -317,28 +318,13 @@ function getAdaptiveImageResourcePath (resourcesDir, type, density, name, source
     return resourcePath;
 }
 
-/**
- * The splashScreenSrc is a .webp image or a .png (or .jpg) image.
- * An inputted .webp should be copied to a screen.webp file.
- * An inputted .png (or .jpg) should be copied to a screen.png file.
- *
- * When a splashscreen is changed from a .png to a .webp or the other way round,
- * the other image must be deleted, to avoid a duplicate resource exception.
- *
- * @param splashScreenSrc
- * @returns {{splashScreenDestToRemove: string, splashScreenDest: string}}
- */
-function buildSplashScreenImageToCopyAndToRemove (splashScreenSrc) {
-    if (path.extname(splashScreenSrc) === '.webp') {
-        return {
-            splashScreenDest: 'screen.webp',
-            splashScreenDestToRemove: 'screen.png'
-        };
-    }
-    return {
-        splashScreenDest: 'screen.png',
-        splashScreenDestToRemove: 'screen.webp'
-    };
+function makeSplashCleanupMap (projectRoot, resourcesDir) {
+    // Build an initial resource map that deletes all existing splash screens
+    const existingSplashPaths = glob.sync(

Review comment:
       Fixed in next commit.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io edited a comment on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-719008097


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=h1) Report
   > Merging [#1113](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=desc) (d79b050) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) (335b0f2) will **increase** coverage by `2.03%`.
   > The diff coverage is `38.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1113/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1113      +/-   ##
   ==========================================
   + Coverage   69.71%   71.74%   +2.03%     
   ==========================================
     Files          20       21       +1     
     Lines        1806     1745      -61     
   ==========================================
   - Hits         1259     1252       -7     
   + Misses        547      493      -54     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `47.79% <38.46%> (+3.88%)` | :arrow_up: |
   | [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `92.85% <0.00%> (-7.15%)` | :arrow_down: |
   | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.84% <0.00%> (+0.71%)` | :arrow_up: |
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (+1.62%)` | :arrow_up: |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `33.33% <0.00%> (+2.22%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=footer). Last update [335b0f2...d79b050](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] timbru31 commented on pull request #1113: WIP: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
timbru31 commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-718511934


   Could you also test if .jpg splashscreen do work? It's stated in the docs, but it seems like that there is a hardcoded check to `screen.png`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer commented on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-724110508


   @erisu and @timbru31  I hate to disturb you guys. But is anyone able to review this PR. Kind regards.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer edited a comment on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer edited a comment on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-719020804


   > Could you also test if .jpg splashscreen do work? It's stated in the docs, but it seems like that there is a hardcoded check to `screen.png`.
   
   @timbru31 Hey I did test the .jpg flow. Really odd, but it works. So what happens, the .jpg is saved as a screen.png in the android project. But android is just displaying it nice. 
   
   A testrepo is available at: https://github.com/PieterVanPoyer/cordova-plugin-splashscreen-testing-app/tree/testing/jpg-splash-screen 
   
   ![image](https://user-images.githubusercontent.com/33040889/97631956-15b80300-1a32-11eb-86f9-cba2bb6c7668.png)
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] raphinesse commented on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-738640457


   @PieterVanPoyer FYI: I made a pull request (https://github.com/PieterVanPoyer/cordova-android/pull/1) against this branch


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] breautek merged pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
breautek merged pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] raphinesse commented on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
raphinesse commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-735372795


   > taking the time to make an issue in the splashscreen plugin to move the splashscreen code to the right place would be a good first step.
   
   Actually, it seems that [we have plans](https://github.com/orgs/apache/projects/2#card-12564932) to move things in the opposite direction. Sorry, I did not remember that. I don't know why this functionality should be moved from plugin to platform, but there is probably a good reason. So the platform seems indeed like the right location for these changes.
   
   I'll get back to you regarding _a more generic way_ to implement this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io commented on pull request #1113: WIP: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-719008097


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=h1) Report
   > Merging [#1113](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **increase** coverage by `0.14%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1113/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1113      +/-   ##
   ==========================================
   + Coverage   69.71%   69.85%   +0.14%     
   ==========================================
     Files          20       20              
     Lines        1806     1788      -18     
   ==========================================
   - Hits         1259     1249      -10     
   + Misses        547      539       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `43.35% <0.00%> (-0.56%)` | :arrow_down: |
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
   | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `33.33% <0.00%> (+2.22%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=footer). Last update [335b0f2...70450b8](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io edited a comment on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-719008097


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=h1) Report
   > Merging [#1113](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=desc) (30bcaa5) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) (335b0f2) will **increase** coverage by `2.03%`.
   > The diff coverage is `38.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1113/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1113      +/-   ##
   ==========================================
   + Coverage   69.71%   71.74%   +2.03%     
   ==========================================
     Files          20       21       +1     
     Lines        1806     1745      -61     
   ==========================================
   - Hits         1259     1252       -7     
   + Misses        547      493      -54     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `47.79% <38.46%> (+3.88%)` | :arrow_up: |
   | [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `92.85% <0.00%> (-7.15%)` | :arrow_down: |
   | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.84% <0.00%> (+0.71%)` | :arrow_up: |
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (+1.62%)` | :arrow_up: |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `33.33% <0.00%> (+2.22%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=footer). Last update [335b0f2...30bcaa5](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io edited a comment on pull request #1113: WIP: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-719008097


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=h1) Report
   > Merging [#1113](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) will **increase** coverage by `0.14%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1113/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1113      +/-   ##
   ==========================================
   + Coverage   69.71%   69.85%   +0.14%     
   ==========================================
     Files          20       20              
     Lines        1806     1788      -18     
   ==========================================
   - Hits         1259     1249      -10     
   + Misses        547      539       -8     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `43.35% <0.00%> (-0.56%)` | :arrow_down: |
   | [bin/templates/cordova/lib/check\_reqs.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9jaGVja19yZXFzLmpz) | `58.49% <0.00%> (-0.48%)` | :arrow_down: |
   | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `33.33% <0.00%> (+2.22%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=footer). Last update [335b0f2...70450b8](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu commented on a change in pull request #1113: WIP: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#discussion_r514294035



##########
File path: bin/templates/cordova/lib/prepare.js
##########
@@ -336,15 +336,27 @@ function updateSplashes (cordovaProject, platformResourcesDir) {
         if (resource.density === 'mdpi') {
             hadMdpi = true;
         }
-        var targetPath = getImageResourcePath(
-            platformResourcesDir, 'drawable', resource.density, 'screen.png', path.basename(resource.src));
+        var targetPath;
+        if (path.extname(resource.src) === '.webp') { // splashsreens could be in .webp format
+            targetPath = getImageResourcePath(
+                platformResourcesDir, 'drawable', resource.density, 'screen.webp', path.basename(resource.src));
+        } else {
+            targetPath = getImageResourcePath(
+                platformResourcesDir, 'drawable', resource.density, 'screen.png', path.basename(resource.src));
+        }

Review comment:
       ```suggestion
           const imgDestExt = path.extname(resource.src) === '.webp' ? '.webp' : '.png';
           const imgDestName = `screen${imgExt}`;
           const targetPath = getImageResourcePath(platformResourcesDir, 'drawable', resource.density, imgDestName, path.basename(resource.src));
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] breautek commented on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
breautek commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-747041339


   Thank you for the review @raphinesse 
   
   Our current dev version is targeting a minor release so I'll go ahead and merge this. Thank you @PieterVanPoyer for your time and effort in preparing this PR!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io edited a comment on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-719008097


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=h1) Report
   > Merging [#1113](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=desc) (d79b050) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) (335b0f2) will **increase** coverage by `2.09%`.
   > The diff coverage is `38.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1113/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1113      +/-   ##
   ==========================================
   + Coverage   69.71%   71.80%   +2.09%     
   ==========================================
     Files          20       21       +1     
     Lines        1806     1745      -61     
   ==========================================
   - Hits         1259     1253       -6     
   + Misses        547      492      -55     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `47.79% <38.46%> (+3.88%)` | :arrow_up: |
   | [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `92.85% <0.00%> (-7.15%)` | :arrow_down: |
   | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.84% <0.00%> (+0.71%)` | :arrow_up: |
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (+1.62%)` | :arrow_up: |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `33.33% <0.00%> (+2.22%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=footer). Last update [335b0f2...d79b050](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] erisu commented on a change in pull request #1113: WIP: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
erisu commented on a change in pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#discussion_r514294035



##########
File path: bin/templates/cordova/lib/prepare.js
##########
@@ -336,15 +336,27 @@ function updateSplashes (cordovaProject, platformResourcesDir) {
         if (resource.density === 'mdpi') {
             hadMdpi = true;
         }
-        var targetPath = getImageResourcePath(
-            platformResourcesDir, 'drawable', resource.density, 'screen.png', path.basename(resource.src));
+        var targetPath;
+        if (path.extname(resource.src) === '.webp') { // splashsreens could be in .webp format
+            targetPath = getImageResourcePath(
+                platformResourcesDir, 'drawable', resource.density, 'screen.webp', path.basename(resource.src));
+        } else {
+            targetPath = getImageResourcePath(
+                platformResourcesDir, 'drawable', resource.density, 'screen.png', path.basename(resource.src));
+        }

Review comment:
       ```suggestion
           const imgDestExt = path.extname(resource.src) === '.webp' ? '.webp' : '.png';
           const imgDestName = `screen${imgExt}`;
           targetPath = getImageResourcePath(platformResourcesDir, 'drawable', resource.density, imgDestName, path.basename(resource.src));
   ```

##########
File path: bin/templates/cordova/lib/prepare.js
##########
@@ -336,15 +336,27 @@ function updateSplashes (cordovaProject, platformResourcesDir) {
         if (resource.density === 'mdpi') {
             hadMdpi = true;
         }
-        var targetPath = getImageResourcePath(
-            platformResourcesDir, 'drawable', resource.density, 'screen.png', path.basename(resource.src));
+        var targetPath;
+        if (path.extname(resource.src) === '.webp') { // splashsreens could be in .webp format
+            targetPath = getImageResourcePath(
+                platformResourcesDir, 'drawable', resource.density, 'screen.webp', path.basename(resource.src));
+        } else {
+            targetPath = getImageResourcePath(
+                platformResourcesDir, 'drawable', resource.density, 'screen.png', path.basename(resource.src));
+        }
         resourceMap[targetPath] = resource.src;
     });
 
     // There's no "default" drawable, so assume default == mdpi.
     if (!hadMdpi && resources.defaultResource) {
-        var targetPath = getImageResourcePath(
-            platformResourcesDir, 'drawable', 'mdpi', 'screen.png', path.basename(resources.defaultResource.src));
+        var targetPath;
+        if (path.extname(resources.defaultResource.src) === '.webp') { // splashsreens could be in .webp format
+            targetPath = getImageResourcePath(
+                platformResourcesDir, 'drawable', 'mdpi', 'screen.webp', path.basename(resources.defaultResource.src));
+        } else {
+            targetPath = getImageResourcePath(
+                platformResourcesDir, 'drawable', 'mdpi', 'screen.png', path.basename(resources.defaultResource.src));
+        }

Review comment:
       ```suggestion
           const imgDestExt = path.extname(resource.src) === '.webp' ? '.webp' : '.png';
           const imgDestName = `screen${imgExt}`;
           const targetPath = getImageResourcePath(platformResourcesDir, 'drawable', 'mdpi', imgDestName, path.basename(resources.defaultResource.src));
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] PieterVanPoyer commented on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
PieterVanPoyer commented on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-735295989


   Hi @raphinesse thanks for your time.
   
   I was also happy with the testcoverage. There were some examples and it was easy to just add my stuff and improve the coverage. And like you said: 'the code is clean'.
   
   I must admit, when I was looking for fixing the issue, I was surprised to find the handling of the splashscreens in the cordova-android lib and not in the plugin code. Unfortunately I cannot shed any light on that matter.
   
   I think making this stuff more generic wouldn't be a real improvement, and I don't exactly know how you'd like that to be. 
   On the other hand, taking the time to make an issue in the splashscreen plugin to move the splashscreen code to the right place would be a good first step.
   When the handling (copying, deleting) of splashscreens is in the plugin, it can be less generic, because that's what the plugin should do. Handling splashscreens.
   
   Kind regards
   Pieter
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org

[GitHub] [cordova-android] codecov-io edited a comment on pull request #1113: Features/webp support for splashscreen

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1113:
URL: https://github.com/apache/cordova-android/pull/1113#issuecomment-719008097


   # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=h1) Report
   > Merging [#1113](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=desc) (30bcaa5) into [master](https://codecov.io/gh/apache/cordova-android/commit/335b0f2575bdcb432583132f17b5f141c64e7c0b?el=desc) (335b0f2) will **increase** coverage by `2.09%`.
   > The diff coverage is `38.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/cordova-android/pull/1113/graphs/tree.svg?width=650&height=150&src=pr&token=q14nMf6C5a)](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1113      +/-   ##
   ==========================================
   + Coverage   69.71%   71.80%   +2.09%     
   ==========================================
     Files          20       21       +1     
     Lines        1806     1745      -61     
   ==========================================
   - Hits         1259     1253       -6     
   + Misses        547      492      -55     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [bin/templates/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9wcmVwYXJlLmpz) | `47.79% <38.46%> (+3.88%)` | :arrow_up: |
   | [bin/templates/cordova/lib/utils.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi91dGlscy5qcw==) | `92.85% <0.00%> (-7.15%)` | :arrow_down: |
   | [bin/templates/cordova/lib/Adb.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9BZGIuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/run.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9ydW4uanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/device.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9kZXZpY2UuanM=) | `100.00% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/target.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi90YXJnZXQuanM=) | `96.77% <0.00%> (ø)` | |
   | [bin/templates/cordova/lib/emulator.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9lbXVsYXRvci5qcw==) | `98.84% <0.00%> (+0.71%)` | :arrow_up: |
   | [...n/templates/cordova/lib/builders/ProjectBuilder.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZGVycy9Qcm9qZWN0QnVpbGRlci5qcw==) | `74.83% <0.00%> (+1.62%)` | :arrow_up: |
   | [bin/templates/cordova/lib/build.js](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9jb3Jkb3ZhL2xpYi9idWlsZC5qcw==) | `33.33% <0.00%> (+2.22%)` | :arrow_up: |
   | ... and [1 more](https://codecov.io/gh/apache/cordova-android/pull/1113/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=footer). Last update [335b0f2...30bcaa5](https://codecov.io/gh/apache/cordova-android/pull/1113?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org