[GitHub] [ozone] bharatviswa504 commented on a change in pull request #2338: HDDS-5341. Container report processing is single threaded

[GitBox <gi...@apache.org>]

bharatviswa504 commented on a change in pull request #2338:
URL: https://github.com/apache/ozone/pull/2338#discussion_r658459386



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/ScmConfigKeys.java
##########
@@ -535,6 +535,13 @@
       "ozone.scm.ca.list.retry.interval";
   public static final long OZONE_SCM_CA_LIST_RETRY_INTERVAL_DEFAULT = 10;
 
+
+  public static final String OZONE_SCM_EVENT_PREFIX = "ozone.scm.event.";
+
+  public static final String OZONE_SCM_EVENT_CONTAINER_REPORT_THREAD_POOL_SIZE =
+      OZONE_SCM_EVENT_PREFIX + "ContainerReport.thread.pool.size";
+  public static final int OZONE_SCM_EVENT_THREAD_POOL_SIZE_DEFAULT = 10;
+

Review comment:
       As the class SingleThreadExecutor is common for all Events, I have named the default variable in a generic way, but the config name construction is done from the event name. As we have more events which need different defaults, this can be revisited if needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org