[GitHub] [mynewt-core] ccollins476ad commented on issue #1945: sys/log: log_fcb_set_watermark to use log_fcb_walk

[GitBox <gi...@apache.org>]

ccollins476ad commented on issue #1945: sys/log: log_fcb_set_watermark to use log_fcb_walk
URL: https://github.com/apache/mynewt-core/pull/1945#issuecomment-518738383
 
 
   The code looks great.  Just a few things:
   
   1. There is a conflict in `log_nmgr.c`.  It is just a whitespace issue, so it should be easy to fix.
   2. Can you please combine the commits into a single commit with a descriptive message?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services