[GitHub] [airflow] bbovenzi opened a new pull request, #24689: Keep grid log scrolling limited to its wrapper div

[GitBox <gi...@apache.org>]

bbovenzi opened a new pull request, #24689:
URL: https://github.com/apache/airflow/pull/24689

   When navigating around the grid view logs, the page would jump around when going to a new log that needed to auto-scroll to the bottom.
   
   Use `block` and `inline` arguments of `scrollIntoView()` so that auto-scrolling only affects the wrapper div of Logs and not the entire page.
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragement file, named `{pr_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi merged pull request #24689: Keep grid log scrolling limited to its wrapper div

[GitBox <gi...@apache.org>]

bbovenzi merged PR #24689:
URL: https://github.com/apache/airflow/pull/24689


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #24689: Keep grid log scrolling limited to its wrapper div

[GitBox <gi...@apache.org>]

github-actions[bot] commented on PR #24689:
URL: https://github.com/apache/airflow/pull/24689#issuecomment-1167988237

   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi commented on pull request #24689: Keep grid log scrolling limited to its wrapper div

[GitBox <gi...@apache.org>]

bbovenzi commented on PR #24689:
URL: https://github.com/apache/airflow/pull/24689#issuecomment-1167959753

   CC @pierrejeambrun 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org