[jira] [Issue Comment Deleted] (AVRO-1853) Compiler::toBin(const std::string& s) crashes on empty string

["Zoltan Ivanfi (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zoltan Ivanfi updated AVRO-1853:
--------------------------------
    Comment: was deleted

(was: I created https://github.com/apache/avro/pull/127 with the fix.)

> Compiler::toBin(const std::string& s) crashes on empty string
> -------------------------------------------------------------
>
>                 Key: AVRO-1853
>                 URL: https://issues.apache.org/jira/browse/AVRO-1853
>             Project: Avro
>          Issue Type: Bug
>          Components: c++
>    Affects Versions: 1.8.1
>         Environment: Win64 debug
>            Reporter: Hans Thulin
>            Assignee: Zoltan Ivanfi
>            Priority: Critical
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Compiler::toBin(const std::string& s) crashes if s is empty. A simple sanity check should fix it:
> static vector<uint8_t> toBin(const std::string& s)
> {
>     vector<uint8_t> result;
>     if(!s.empty())
>     {   
>         result.resize(s.size());
>         std::copy(s.c_str(), s.c_str() + s.size(), &result[0]);
>     }
>     return result;
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)