You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apex.apache.org by vrozov <gi...@git.apache.org> on 2016/02/28 20:33:02 UTC
[GitHub] incubator-apex-core pull request: APEXCORE-363 - NPE in StreamingC...
GitHub user vrozov opened a pull request:
https://github.com/apache/incubator-apex-core/pull/247
APEXCORE-363 - NPE in StreamingContainerManager.
Skip null in the statistics list in case it was inserted as a result of incorrect CircularBuffer usage in the OperatorContext.
@tweise please cherry pick into all affected releases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vrozov/incubator-apex-core APEXCORE-363
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-apex-core/pull/247.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #247
----
commit ed962c9769ed7948059a9b45d5c572c0dde8e6ba
Author: Vlad Rozov <v....@datatorrent.com>
Date: 2016-02-28T17:55:48Z
APEXCORE-363 - NPE in StreamingContainerManager. Skip null in the statistics list in case it was inserted as a result of incorrect CircularBuffer usage in the OperatorContext.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-363 - NPE in StreamingC...
Posted by tweise <gi...@git.apache.org>.
Github user tweise commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/247#discussion_r54358885
--- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java ---
@@ -1558,6 +1558,10 @@ public void run()
entry.getValue().recordingId = null;
}
for (ContainerStats.OperatorStats stats : statsList) {
+ if (stats == null) {
--- End diff --
I'm going to merge it, but shouldn't we ensure in the container that we don't put null elements into the heartbeat data?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-363 - NPE in StreamingC...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-apex-core/pull/247
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-apex-core pull request: APEXCORE-363 - NPE in StreamingC...
Posted by vrozov <gi...@git.apache.org>.
Github user vrozov commented on a diff in the pull request:
https://github.com/apache/incubator-apex-core/pull/247#discussion_r54359261
--- Diff: engine/src/main/java/com/datatorrent/stram/StreamingContainerManager.java ---
@@ -1558,6 +1558,10 @@ public void run()
entry.getValue().recordingId = null;
}
for (ContainerStats.OperatorStats stats : statsList) {
+ if (stats == null) {
--- End diff --
Yes, I'll file another JIRA to correct CircularBuffer usage (single producer/single consumer contract) in the container.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---