You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/06/11 08:17:24 UTC

[GitHub] [flink] shaomengwang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package

shaomengwang commented on a change in pull request #8632: [FLINK-12744][ml] add shared params in ml package
URL: https://github.com/apache/flink/pull/8632#discussion_r292330908
 
 

 ##########
 File path: flink-ml-parent/pom.xml
 ##########
 @@ -35,5 +35,6 @@ under the License.
 
 	<modules>
 		<module>flink-ml-api</module>
+		<module>flink-ml</module>
 
 Review comment:
   There are two suggestions for the name of ml package
   * as the subdirectory of flink-ml-parent，flink-ml is simpler
   * the new ml package with pipeline api in spark is named ml
   
   +1 for flink-ml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services