[axis2] Fault info (was Re: [Axis2] Why does 0.92 upgrade make my .aar files invalid?)

[Glen Daniels <gl...@thoughtcraft.com>]

Sanjiva says:
> +1 for logging a more detailed error saying "services.xml" is not found.

+1... which reminds me:

In general, I've noticed a lot of this kind of stuff:

String thing = lookupThingByQName(qname);
if (thing == null) {
    throw new Exception("Thing not found!");
}

We should include as much information as possible for failure, so this is 
much better:

String thing = lookupThingByQName(qname);
if (thing == null) {
    throw new Exception("Thing not found for qname '" + qname + "'!");
}

Please make fault messages as complete as possible as you go.  Thanks!

--Glen

Re: [axis2] Fault info (was Re: [Axis2] Why does 0.92 upgrade make my .aar files invalid?)

[Steve Loughran <st...@apache.org>]

Glen Daniels wrote:
> Sanjiva says:
> 
>> +1 for logging a more detailed error saying "services.xml" is not found.
> 
> 
> +1... which reminds me:
> 
> In general, I've noticed a lot of this kind of stuff:
> 
> String thing = lookupThingByQName(qname);
> if (thing == null) {
>    throw new Exception("Thing not found!");
> }
> 
> We should include as much information as possible for failure, so this 
> is much better:
> 
> String thing = lookupThingByQName(qname);
> if (thing == null) {
>    throw new Exception("Thing not found for qname '" + qname + "'!");
> }
> 
> Please make fault messages as complete as possible as you go.  Thanks!
> 
> --Glen
> 
or better yeat

  lookupThingByQnameFaulting(Qname thing)

with the faulting factored out