[jira] Commented: (TAPESTRY-1878) RootPathDispatcher drops any returned ResponseGenerator from the startPage

["Nick Westgate (JIRA)" <de...@tapestry.apache.org>]

    [ https://issues.apache.org/jira/browse/TAPESTRY-1878?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539782 ] 

Nick Westgate commented on TAPESTRY-1878:
-----------------------------------------

This is a duplicate of TAPESTRY-1627.
I've added a patch there, and also an AppModule runtime patch.

Cheers,
Nick.

> RootPathDispatcher drops any returned ResponseGenerator from the startPage
> --------------------------------------------------------------------------
>
>                 Key: TAPESTRY-1878
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1878
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0, 5.0.3, 5.0.4, 5.0.5, 5.0.6, 5.0.7
>            Reporter: Fernando
>
> I had a start page that actually returned a ResponseGenerator to force a redirect.  It works when I went to "/start", but failed when I went to "/".
> Comparing the RootPathDispatcher with the PageRenderDispatcher, I noticed that it doesn't do anything with the possible responseGenerator returned by the start page.
> I simply propose to add the following line:
> OLD:
> _handler.handle(_startPageName, _emptyContext);
> NEW:
> ActionResponseGenerator responseGenerator = _handler.handle(_startPageName, _emptyContext);
> if (responseGenerator != null) responseGenerator.sendClientResponse(response);

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org