Re: dojo version in struts 2.0.11?

[Ted Husted <hu...@apache.org>]

Moving this to dev@.

> The rest would be deleting everything related to dojo from core.

Would that be optional or required. The idea was being able to drop
the Dojo 2.1.0 plugin with the Struts 2.0.x JARs, and being able to
run it out-of-the-box.

> The plugin code itself can be just copied to 2.0 and it should work.

And, just to ask the question, would moving Dojo from a theme to a
plugin be too much of a change for the 2.0.x series?

-Ted.

On Nov 11, 2007 2:19 AM, Musachy Barroso <mu...@gmail.com> wrote:
> The plugin code itself can be just copied to 2.0 and it should work.
> The rest would be deleting everything related to dojo from core.
>
> musachy
>
>
> On Nov 11, 2007 1:20 AM, Dave Newton <ne...@yahoo.com> wrote:
> > --- Ted Husted <hu...@apache.org> wrote:
> > > I wonder if it would be possible to retrofit the 2.1
> > > Dojo plugin for 2.0?
> >
> > I haven't started looking in to this in any depth (and
> > my initial naïve test didn't work) but aside from the
> > hard-coded theme name that has to be changed to not
> > conflict w/ the bundled templates and some XWork
> > 2.1/S2.1 stuff it shouldn't be a *huge* effort, but
> > Musachy's obviously the guy to ask about this.
> >
> > d.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org

Re: dojo version in struts 2.0.11?

[Dave Newton <ne...@yahoo.com>]

--- Ted Husted <hu...@apache.org> wrote:
> > The rest would be deleting everything related to
> dojo from core.
> 
> Would that be optional or required.

Required with the current Dojo plugin source: the
tag's theme is hardcoded, and AFAICT with the original
themes in place they take precedence. 

For a separate work-related issue I hardcoded a
different theme into the plugin and that fixed that
issue.

There is some XWork 2.1-specific logging (not sure why
the change from commons-logging) but that was only in
a couple of spots, and there's one annotation
(@StrutsTagSkipInheritance) that isn't in 2.0 but I'm
not sure if that's only a compile issue or not
(haven't looked at it yet).

> And, just to ask the question, would moving Dojo
> from a theme to a plugin be too much of a change
>for the 2.0.x series?

It doesn't seem like it, the logging is a non-issue if
we switch the few classes to commons-logging, not sure
about the inheritence thing but it doesn't seem like
an issue.

All that said as I mentioned on struts-user my first
naïve test didn't run, but I can re-visit it tonight.

d.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org