You are viewing a plain text version of this content. The canonical link for it is here.
Posted to general@incubator.apache.org by Ethan Feng <et...@apache.org> on 2023/02/24 03:47:36 UTC
[VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Hello Incubator Community,
This is a call for a vote to release Apache Celeborn(Incubating)
version 0.2.0-incubating-rc5
The Apache Celeborn community has voted on and approved a proposal to release
Apache Celeborn(Incubating) version 0.2.0-incubating-rc5
We now kindly request the Incubator PMC members review and vote on this
incubator release.
Celeborn community vote thread:
• https://lists.apache.org/thread/6f28tyvqsqdpjr0wpg2low4hlh39bx4j
Vote result thread:
• https://lists.apache.org/thread/9bhflkrwrmk81w1stbhvztzc6mb6gjco
The release candidate:
• https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc5
Git tag for the release:
• https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc5
Public keys file:
• https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
The change log is available in:
• https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc5
The vote will be open for at least 72 hours or until the necessary number
of votes are reached.
Please vote accordingly:
[ ] +1 approve
[ ] +0 no opinion
[ ] -1 disapprove with the reason
More detailed checklist please refer:
• https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
Steps to validate the release， Please refer to:
• https://www.apache.org/info/verification.html
Thanks,
Ethan Feng
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by Yu Li <ca...@gmail.com>.
+1 (binding)
- Checked release file name and location: *OK*
- Checked sum and signatures: *OK*
- Checked DISCLAIMER file exists: *OK*
- Checked LICENSE and NOTICE files: *OK*
* License of 3rd-party code contained correctly mentioned in LICENSE:
*OK*
* Included dependencies are mentioned in LICENSE: *OK*
* Un-included software dependencies are not mentioned in LICENSE or
NOTICE: *OK*
* Relevant part of NOTICE files of referred/contained ASF codes added
into NOTICE: *OK*
* NOTICE year: *OK*
- Checked no binary files in source package: *OK*
- Checked compile from source: *OK* (JDK 8u181)
- Checked UT could pass: *OK* (JDK 8u181)
Best Regards,
Yu
On Fri, 24 Feb 2023 at 14:06, Kent Yao <ya...@apache.org> wrote:
> +1 non-binding
>
> incubating in the name
> sig and checksum are valid
> DISCLAIMER/LICENSE/NOTICE are fine
> no unexpected binaries in the source
> ASF headers on source files are fine.
>
> Kent
>
> On 2023/02/24 04:38:23 Justin Mclean wrote:
> > Hi,
> >
> > +1 (binding)
> >
> > I checked:
> > - incubating in the name
> > - signature and hashes are fine
> > - DISCLAIMER exists
> > - LICENSE and NOTICE are fine
> > - No unexpected binary files
> > - ASF headers on source files
> > - Can compile from source
> >
> > I dislike "Copyright 2014 and onwards", but that's Spark's issue, not
> yours. I wonder if you need an ASF header on [1]. The ASF header states
> "Licensed to the Apache Software Foundation (ASF) under one or more
> contributor license agreements." is this true for this file?
> >
> > Kind Regards,
> > Justin
> >
> > 1.
> ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by Kent Yao <ya...@apache.org>.
+1 non-binding
incubating in the name
sig and checksum are valid
DISCLAIMER/LICENSE/NOTICE are fine
no unexpected binaries in the source
ASF headers on source files are fine.
Kent
On 2023/02/24 04:38:23 Justin Mclean wrote:
> Hi,
>
> +1 (binding)
>
> I checked:
> - incubating in the name
> - signature and hashes are fine
> - DISCLAIMER exists
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - ASF headers on source files
> - Can compile from source
>
> I dislike "Copyright 2014 and onwards", but that's Spark's issue, not yours. I wonder if you need an ASF header on [1]. The ASF header states "Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements." is this true for this file?
>
> Kind Regards,
> Justin
>
> 1. ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
It looks like Spark may have incorrectly added that header. You could ask them why it was added perhaps or just leave it as is.
Kind Regards,
Justin
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by Keyong Zhou <zh...@apache.org>.
Hi Justin and Willem,
Thanks for your feedback!
The file [1] is based on Spark's file[2], we had very little modification,
and we leave the ASF header unmodified as it is[2].
We will remove the header in later releases.
Thanks,
Keyong Zhou
1.
./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
2.
https://github.com/apache/spark/blob/v3.1.1/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java
Justin Mclean <ju...@classsoftware.com> 于2023年2月24日周五 12:38写道：
> Hi,
>
> +1 (binding)
>
> I checked:
> - incubating in the name
> - signature and hashes are fine
> - DISCLAIMER exists
> - LICENSE and NOTICE are fine
> - No unexpected binary files
> - ASF headers on source files
> - Can compile from source
>
> I dislike "Copyright 2014 and onwards", but that's Spark's issue, not
> yours. I wonder if you need an ASF header on [1]. The ASF header states
> "Licensed to the Apache Software Foundation (ASF) under one or more
> contributor license agreements." is this true for this file?
>
> Kind Regards,
> Justin
>
> 1.
> ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
+1 (binding)
I checked:
- incubating in the name
- signature and hashes are fine
- DISCLAIMER exists
- LICENSE and NOTICE are fine
- No unexpected binary files
- ASF headers on source files
- Can compile from source
I dislike "Copyright 2014 and onwards", but that's Spark's issue, not yours. I wonder if you need an ASF header on [1]. The ASF header states "Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements." is this true for this file?
Kind Regards,
Justin
1. ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by Ethan Feng <et...@gmail.com>.
Thanks everyone for suggestions and feedback, I will close this vote
thread and announce the results soon since 72 hours have passed.
Ethan Feng.
keyong zhou <wa...@gmail.com> 于2023年3月1日周三 11:48写道：
>
> Hi Gang,
>
> Thanks for you feedback!
>
> We do keep contents of the original NOTICE file of `log4j-core-2.17.2.jar`
> without [1], but separate [2] and [3] for alphabetical ordering.
> We will put [2] and [3] together in future releases.
>
> Thanks,
> Keyong Zhou
>
> [1] `This product includes software developed at The Apache Software
> Foundation (http://www.apache.org/).`
> [2] `Apache Log4j Core Copyright 1999-2012 Apache Software Foundation`
> [3] `ResolverUtil.java Copyright 2005-2006 Tim Fennell`
>
> li gang <lg...@apache.org> 于2023年2月28日周二 19:11写道：
>
> > Thanks for the PR link [1].It explained the content [2] is copied from the
> > NOTICE of `log4j-core-2.17.2.jar`,It's right to keep it in the NOTICE file.
> >
> > BTW,I suggest keep the original NOTICE file of `log4j-core-2.17.2.jar`,of
> > course can remove the content [3].
> > It might be easier to see which dependency [2] comes from.
> >
> > 1.
> >
> > https://github.com/apache/incubator-celeborn/pull/1189#discussion_r1092932857
> > 2.`ResolverUtil.java Copyright 2005-2006 Tim Fennell`
> > 3.`This product includes software developed at
> > The Apache Software Foundation (http://www.apache.org/).`
> > <http://www.apache.org/).>
> >
> > Yu Li <ca...@gmail.com> 于2023年2月27日周一 18:54写道：
> >
> > > @Gang
> > > About the ResolverUtil.java Copyright occurring in the NOTICE file of the
> > > binary release, it's a transitive dependency from log4j-core. The same
> > > question was raised and discussed in a previous PR review [1] thus I have
> > > the memory, JFYI.
> > >
> > > Best Regards,
> > > Yu
> > >
> > > [1]
> > >
> > >
> > https://github.com/apache/incubator-celeborn/pull/1189#discussion_r1092932857
> > >
> > >
> > > On Sun, 26 Feb 2023 at 12:31, li gang <lg...@apache.org> wrote:
> > >
> > > > +1 (binding)
> > > > I checked
> > > > - Files have the word incubating in their name.
> > > > - DISCLAIMER,LICENSE and NOTICE files exist.qq
> > > > - Checksums and signatures are valid.
> > > > - No unexpected binary files in the source release.
> > > >
> > > > The NOTICE file under binary release contains unexpected content
> > > > `ResolverUtil.java Copyright 2005-2006 Tim Fennell`,please remove it
> > and
> > > > check whether `ResolverUtil.java` is the third-pary work.
> > > >
> > > > Ethan Feng <et...@apache.org> 于2023年2月24日周五 11:48写道：
> > > >
> > > > > Hello Incubator Community,
> > > > >
> > > > > This is a call for a vote to release Apache Celeborn(Incubating)
> > > > > version 0.2.0-incubating-rc5
> > > > >
> > > > > The Apache Celeborn community has voted on and approved a proposal to
> > > > > release
> > > > > Apache Celeborn(Incubating) version 0.2.0-incubating-rc5
> > > > >
> > > > > We now kindly request the Incubator PMC members review and vote on
> > this
> > > > > incubator release.
> > > > >
> > > > > Celeborn community vote thread:
> > > > > • https://lists.apache.org/thread/6f28tyvqsqdpjr0wpg2low4hlh39bx4j
> > > > >
> > > > > Vote result thread:
> > > > > • https://lists.apache.org/thread/9bhflkrwrmk81w1stbhvztzc6mb6gjco
> > > > >
> > > > > The release candidate:
> > > > > •
> > > > >
> > > >
> > >
> > https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc5
> > > > >
> > > > > Git tag for the release:
> > > > > •
> > > > >
> > > >
> > >
> > https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc5
> > > > >
> > > > > Public keys file:
> > > > > • https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> > > > >
> > > > > The change log is available in:
> > > > > •
> > > > >
> > > >
> > >
> > https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc5
> > > > >
> > > > > The vote will be open for at least 72 hours or until the necessary
> > > number
> > > > > of votes are reached.
> > > > >
> > > > > Please vote accordingly:
> > > > > [ ] +1 approve
> > > > > [ ] +0 no opinion
> > > > > [ ] -1 disapprove with the reason
> > > > >
> > > > > More detailed checklist please refer:
> > > > > •
> > > > >
> > > >
> > >
> > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > > > >
> > > > > Steps to validate the release， Please refer to:
> > > > > • https://www.apache.org/info/verification.html
> > > > >
> > > > > Thanks,
> > > > > Ethan Feng
> > > > >
> > > > > ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > > > For additional commands, e-mail: general-help@incubator.apache.org
> > > > >
> > > > >
> > > >
> > > > --
> > > >
> > > >
> > > > ------------------------------
> > > > Best Regards
> > > >
> > > > DolphinScheduler PMC
> > > > Gang Li 李岗
> > > >
> > > > lgcareer@apache.org
> > > >
> > >
> >
> >
> > --
> >
> >
> > ------------------------------
> > Best Regards
> >
> > DolphinScheduler PMC
> > Gang Li 李岗
> >
> > lgcareer@apache.org
> >
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by keyong zhou <wa...@gmail.com>.
Hi Gang,
Thanks for you feedback!
We do keep contents of the original NOTICE file of `log4j-core-2.17.2.jar`
without [1], but separate [2] and [3] for alphabetical ordering.
We will put [2] and [3] together in future releases.
Thanks,
Keyong Zhou
[1] `This product includes software developed at The Apache Software
Foundation (http://www.apache.org/).`
[2] `Apache Log4j Core Copyright 1999-2012 Apache Software Foundation`
[3] `ResolverUtil.java Copyright 2005-2006 Tim Fennell`
li gang <lg...@apache.org> 于2023年2月28日周二 19:11写道：
> Thanks for the PR link [1].It explained the content [2] is copied from the
> NOTICE of `log4j-core-2.17.2.jar`,It's right to keep it in the NOTICE file.
>
> BTW,I suggest keep the original NOTICE file of `log4j-core-2.17.2.jar`,of
> course can remove the content [3].
> It might be easier to see which dependency [2] comes from.
>
> 1.
>
> https://github.com/apache/incubator-celeborn/pull/1189#discussion_r1092932857
> 2.`ResolverUtil.java Copyright 2005-2006 Tim Fennell`
> 3.`This product includes software developed at
> The Apache Software Foundation (http://www.apache.org/).`
> <http://www.apache.org/).>
>
> Yu Li <ca...@gmail.com> 于2023年2月27日周一 18:54写道：
>
> > @Gang
> > About the ResolverUtil.java Copyright occurring in the NOTICE file of the
> > binary release, it's a transitive dependency from log4j-core. The same
> > question was raised and discussed in a previous PR review [1] thus I have
> > the memory, JFYI.
> >
> > Best Regards,
> > Yu
> >
> > [1]
> >
> >
> https://github.com/apache/incubator-celeborn/pull/1189#discussion_r1092932857
> >
> >
> > On Sun, 26 Feb 2023 at 12:31, li gang <lg...@apache.org> wrote:
> >
> > > +1 (binding)
> > > I checked
> > > - Files have the word incubating in their name.
> > > - DISCLAIMER,LICENSE and NOTICE files exist.qq
> > > - Checksums and signatures are valid.
> > > - No unexpected binary files in the source release.
> > >
> > > The NOTICE file under binary release contains unexpected content
> > > `ResolverUtil.java Copyright 2005-2006 Tim Fennell`,please remove it
> and
> > > check whether `ResolverUtil.java` is the third-pary work.
> > >
> > > Ethan Feng <et...@apache.org> 于2023年2月24日周五 11:48写道：
> > >
> > > > Hello Incubator Community,
> > > >
> > > > This is a call for a vote to release Apache Celeborn(Incubating)
> > > > version 0.2.0-incubating-rc5
> > > >
> > > > The Apache Celeborn community has voted on and approved a proposal to
> > > > release
> > > > Apache Celeborn(Incubating) version 0.2.0-incubating-rc5
> > > >
> > > > We now kindly request the Incubator PMC members review and vote on
> this
> > > > incubator release.
> > > >
> > > > Celeborn community vote thread:
> > > > • https://lists.apache.org/thread/6f28tyvqsqdpjr0wpg2low4hlh39bx4j
> > > >
> > > > Vote result thread:
> > > > • https://lists.apache.org/thread/9bhflkrwrmk81w1stbhvztzc6mb6gjco
> > > >
> > > > The release candidate:
> > > > •
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc5
> > > >
> > > > Git tag for the release:
> > > > •
> > > >
> > >
> >
> https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc5
> > > >
> > > > Public keys file:
> > > > • https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> > > >
> > > > The change log is available in:
> > > > •
> > > >
> > >
> >
> https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc5
> > > >
> > > > The vote will be open for at least 72 hours or until the necessary
> > number
> > > > of votes are reached.
> > > >
> > > > Please vote accordingly:
> > > > [ ] +1 approve
> > > > [ ] +0 no opinion
> > > > [ ] -1 disapprove with the reason
> > > >
> > > > More detailed checklist please refer:
> > > > •
> > > >
> > >
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > > >
> > > > Steps to validate the release， Please refer to:
> > > > • https://www.apache.org/info/verification.html
> > > >
> > > > Thanks,
> > > > Ethan Feng
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > > For additional commands, e-mail: general-help@incubator.apache.org
> > > >
> > > >
> > >
> > > --
> > >
> > >
> > > ------------------------------
> > > Best Regards
> > >
> > > DolphinScheduler PMC
> > > Gang Li 李岗
> > >
> > > lgcareer@apache.org
> > >
> >
>
>
> --
>
>
> ------------------------------
> Best Regards
>
> DolphinScheduler PMC
> Gang Li 李岗
>
> lgcareer@apache.org
>
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by li gang <lg...@apache.org>.
Thanks for the PR link [1].It explained the content [2] is copied from the
NOTICE of `log4j-core-2.17.2.jar`,It's right to keep it in the NOTICE file.
BTW,I suggest keep the original NOTICE file of `log4j-core-2.17.2.jar`,of
course can remove the content [3].
It might be easier to see which dependency [2] comes from.
1.
https://github.com/apache/incubator-celeborn/pull/1189#discussion_r1092932857
2.`ResolverUtil.java Copyright 2005-2006 Tim Fennell`
3.`This product includes software developed at
The Apache Software Foundation (http://www.apache.org/).`
Yu Li <ca...@gmail.com> 于2023年2月27日周一 18:54写道：
> @Gang
> About the ResolverUtil.java Copyright occurring in the NOTICE file of the
> binary release, it's a transitive dependency from log4j-core. The same
> question was raised and discussed in a previous PR review [1] thus I have
> the memory, JFYI.
>
> Best Regards,
> Yu
>
> [1]
>
> https://github.com/apache/incubator-celeborn/pull/1189#discussion_r1092932857
>
>
> On Sun, 26 Feb 2023 at 12:31, li gang <lg...@apache.org> wrote:
>
> > +1 (binding)
> > I checked
> > - Files have the word incubating in their name.
> > - DISCLAIMER,LICENSE and NOTICE files exist.qq
> > - Checksums and signatures are valid.
> > - No unexpected binary files in the source release.
> >
> > The NOTICE file under binary release contains unexpected content
> > `ResolverUtil.java Copyright 2005-2006 Tim Fennell`,please remove it and
> > check whether `ResolverUtil.java` is the third-pary work.
> >
> > Ethan Feng <et...@apache.org> 于2023年2月24日周五 11:48写道：
> >
> > > Hello Incubator Community,
> > >
> > > This is a call for a vote to release Apache Celeborn(Incubating)
> > > version 0.2.0-incubating-rc5
> > >
> > > The Apache Celeborn community has voted on and approved a proposal to
> > > release
> > > Apache Celeborn(Incubating) version 0.2.0-incubating-rc5
> > >
> > > We now kindly request the Incubator PMC members review and vote on this
> > > incubator release.
> > >
> > > Celeborn community vote thread:
> > > • https://lists.apache.org/thread/6f28tyvqsqdpjr0wpg2low4hlh39bx4j
> > >
> > > Vote result thread:
> > > • https://lists.apache.org/thread/9bhflkrwrmk81w1stbhvztzc6mb6gjco
> > >
> > > The release candidate:
> > > •
> > >
> >
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc5
> > >
> > > Git tag for the release:
> > > •
> > >
> >
> https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc5
> > >
> > > Public keys file:
> > > • https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> > >
> > > The change log is available in:
> > > •
> > >
> >
> https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc5
> > >
> > > The vote will be open for at least 72 hours or until the necessary
> number
> > > of votes are reached.
> > >
> > > Please vote accordingly:
> > > [ ] +1 approve
> > > [ ] +0 no opinion
> > > [ ] -1 disapprove with the reason
> > >
> > > More detailed checklist please refer:
> > > •
> > >
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> > >
> > > Steps to validate the release， Please refer to:
> > > • https://www.apache.org/info/verification.html
> > >
> > > Thanks,
> > > Ethan Feng
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > > For additional commands, e-mail: general-help@incubator.apache.org
> > >
> > >
> >
> > --
> >
> >
> > ------------------------------
> > Best Regards
> >
> > DolphinScheduler PMC
> > Gang Li 李岗
> >
> > lgcareer@apache.org
> >
>
--
------------------------------
Best Regards
DolphinScheduler PMC
Gang Li 李岗
lgcareer@apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by Yu Li <ca...@gmail.com>.
@Gang
About the ResolverUtil.java Copyright occurring in the NOTICE file of the
binary release, it's a transitive dependency from log4j-core. The same
question was raised and discussed in a previous PR review [1] thus I have
the memory, JFYI.
Best Regards,
Yu
[1]
https://github.com/apache/incubator-celeborn/pull/1189#discussion_r1092932857
On Sun, 26 Feb 2023 at 12:31, li gang <lg...@apache.org> wrote:
> +1 (binding)
> I checked
> - Files have the word incubating in their name.
> - DISCLAIMER,LICENSE and NOTICE files exist.qq
> - Checksums and signatures are valid.
> - No unexpected binary files in the source release.
>
> The NOTICE file under binary release contains unexpected content
> `ResolverUtil.java Copyright 2005-2006 Tim Fennell`,please remove it and
> check whether `ResolverUtil.java` is the third-pary work.
>
> Ethan Feng <et...@apache.org> 于2023年2月24日周五 11:48写道：
>
> > Hello Incubator Community,
> >
> > This is a call for a vote to release Apache Celeborn(Incubating)
> > version 0.2.0-incubating-rc5
> >
> > The Apache Celeborn community has voted on and approved a proposal to
> > release
> > Apache Celeborn(Incubating) version 0.2.0-incubating-rc5
> >
> > We now kindly request the Incubator PMC members review and vote on this
> > incubator release.
> >
> > Celeborn community vote thread:
> > • https://lists.apache.org/thread/6f28tyvqsqdpjr0wpg2low4hlh39bx4j
> >
> > Vote result thread:
> > • https://lists.apache.org/thread/9bhflkrwrmk81w1stbhvztzc6mb6gjco
> >
> > The release candidate:
> > •
> >
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc5
> >
> > Git tag for the release:
> > •
> >
> https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc5
> >
> > Public keys file:
> > • https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
> >
> > The change log is available in:
> > •
> >
> https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc5
> >
> > The vote will be open for at least 72 hours or until the necessary number
> > of votes are reached.
> >
> > Please vote accordingly:
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove with the reason
> >
> > More detailed checklist please refer:
> > •
> >
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
> >
> > Steps to validate the release， Please refer to:
> > • https://www.apache.org/info/verification.html
> >
> > Thanks,
> > Ethan Feng
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> > For additional commands, e-mail: general-help@incubator.apache.org
> >
> >
>
> --
>
>
> ------------------------------
> Best Regards
>
> DolphinScheduler PMC
> Gang Li 李岗
>
> lgcareer@apache.org
>
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by li gang <lg...@apache.org>.
+1 (binding)
I checked
- Files have the word incubating in their name.
- DISCLAIMER,LICENSE and NOTICE files exist.qq
- Checksums and signatures are valid.
- No unexpected binary files in the source release.
The NOTICE file under binary release contains unexpected content
`ResolverUtil.java Copyright 2005-2006 Tim Fennell`,please remove it and
check whether `ResolverUtil.java` is the third-pary work.
Ethan Feng <et...@apache.org> 于2023年2月24日周五 11:48写道：
> Hello Incubator Community,
>
> This is a call for a vote to release Apache Celeborn(Incubating)
> version 0.2.0-incubating-rc5
>
> The Apache Celeborn community has voted on and approved a proposal to
> release
> Apache Celeborn(Incubating) version 0.2.0-incubating-rc5
>
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
> Celeborn community vote thread:
> • https://lists.apache.org/thread/6f28tyvqsqdpjr0wpg2low4hlh39bx4j
>
> Vote result thread:
> • https://lists.apache.org/thread/9bhflkrwrmk81w1stbhvztzc6mb6gjco
>
> The release candidate:
> •
> https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc5
>
> Git tag for the release:
> •
> https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc5
>
> Public keys file:
> • https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>
> The change log is available in:
> •
> https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc5
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> More detailed checklist please refer:
> •
> https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> Steps to validate the release， Please refer to:
> • https://www.apache.org/info/verification.html
>
> Thanks,
> Ethan Feng
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
>
--
------------------------------
Best Regards
DolphinScheduler PMC
Gang Li 李岗
lgcareer@apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc5
Posted by Willem Jiang <wi...@gmail.com>.
+1 (binding)
I checked the src kits:
- incubating in the release kit name
- The checksums and signatures are validated.
- The LICENSE and NOTICE files look good to me.
- There is a DISCLAIMER in the release kits
- No binary files in the source release kits
- I can build the source
I have the same question as Justin asked, do we need to add the ASF
License header to this file[1]?
[1] ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java
Willem Jiang
Twitter: willemjiang
Weibo: 姜宁willem
On Fri, Feb 24, 2023 at 11:48 AM Ethan Feng <et...@apache.org> wrote:
>
> Hello Incubator Community,
>
> This is a call for a vote to release Apache Celeborn(Incubating)
> version 0.2.0-incubating-rc5
>
> The Apache Celeborn community has voted on and approved a proposal to release
> Apache Celeborn(Incubating) version 0.2.0-incubating-rc5
>
> We now kindly request the Incubator PMC members review and vote on this
> incubator release.
>
> Celeborn community vote thread:
> • https://lists.apache.org/thread/6f28tyvqsqdpjr0wpg2low4hlh39bx4j
>
> Vote result thread:
> • https://lists.apache.org/thread/9bhflkrwrmk81w1stbhvztzc6mb6gjco
>
> The release candidate:
> • https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc5
>
> Git tag for the release:
> • https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc5
>
> Public keys file:
> • https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS
>
> The change log is available in:
> • https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc5
>
> The vote will be open for at least 72 hours or until the necessary number
> of votes are reached.
>
> Please vote accordingly:
> [ ] +1 approve
> [ ] +0 no opinion
> [ ] -1 disapprove with the reason
>
> More detailed checklist please refer:
> • https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist
>
> Steps to validate the release， Please refer to:
> • https://www.apache.org/info/verification.html
>
> Thanks,
> Ethan Feng
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
> For additional commands, e-mail: general-help@incubator.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: general-unsubscribe@incubator.apache.org
For additional commands, e-mail: general-help@incubator.apache.org