You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/31 16:49:42 UTC
[GitHub] [rocketmq-connect] ingdex opened a new pull request, #299: add doris sink connector
ingdex opened a new pull request, #299:
URL: https://github.com/apache/rocketmq-connect/pull/299
add doris sink connector
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] ingdex closed pull request #299: add doris sink connector
Posted by GitBox <gi...@apache.org>.
ingdex closed pull request #299: add doris sink connector
URL: https://github.com/apache/rocketmq-connect/pull/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] francisoliverlee commented on pull request #299: add doris sink connector
Posted by GitBox <gi...@apache.org>.
francisoliverlee commented on PR #299:
URL: https://github.com/apache/rocketmq-connect/pull/299#issuecomment-1235015491
some opts
1. English would be better on this repo, the worlds could see your code and docs, not only Chinese
2. useless code should be removed, such as pom.xml, *.java,
3. update code style by exec `mvn checkstyle:check` until all passed
4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] sunxiaojian commented on pull request #299: add doris sink connector
Posted by GitBox <gi...@apache.org>.
sunxiaojian commented on PR #299:
URL: https://github.com/apache/rocketmq-connect/pull/299#issuecomment-1234987509
> add doris sink connector
Try to use checkstyle to check the code to ensure that it can pass the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] ingdex commented on pull request #299: add doris sink connector
Posted by GitBox <gi...@apache.org>.
ingdex commented on PR #299:
URL: https://github.com/apache/rocketmq-connect/pull/299#issuecomment-1236369877
#299 was closd by accident, new pr is #302
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] ingdex commented on pull request #299: add doris sink connector
Posted by GitBox <gi...@apache.org>.
ingdex commented on PR #299:
URL: https://github.com/apache/rocketmq-connect/pull/299#issuecomment-1236366589
Thanks for suggestion, code refactoring has been done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-connect] ingdex closed pull request #299: add doris sink connector
Posted by GitBox <gi...@apache.org>.
ingdex closed pull request #299: add doris sink connector
URL: https://github.com/apache/rocketmq-connect/pull/299
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org