You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Brock Noland <br...@cloudera.com> on 2014/03/07 18:23:20 UTC

Review Request 18911: SENTRY-133 - Alter table create partition if not exists - results in error

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18911/
-----------------------------------------------------------

Review request for sentry, Jarek Cecho and Shreepadma Venugopalan.


Bugs: SENTRY-133
    https://issues.apache.org/jira/browse/SENTRY-133


Repository: sentry


Description
-------

Fixes the issue with the extra IF NOT EXISTS clause.


Diffs
-----

  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 3624e8f 
  sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindingHook.java PRE-CREATION 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 7fd2470 

Diff: https://reviews.apache.org/r/18911/diff/


Testing
-------

Adds new unit tests for this specific section of code in addition to new integration tests.


Thanks,

Brock Noland


Re: Review Request 18911: SENTRY-133 - Alter table create partition if not exists - results in error

Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18911/#review36548
-----------------------------------------------------------

Ship it!


Ship It!

- Jarek Cecho


On March 7, 2014, 5:23 p.m., Brock Noland wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18911/
> -----------------------------------------------------------
> 
> (Updated March 7, 2014, 5:23 p.m.)
> 
> 
> Review request for sentry, Jarek Cecho and Shreepadma Venugopalan.
> 
> 
> Bugs: SENTRY-133
>     https://issues.apache.org/jira/browse/SENTRY-133
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> Fixes the issue with the extra IF NOT EXISTS clause.
> 
> 
> Diffs
> -----
> 
>   sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/hive/HiveAuthzBindingHook.java 3624e8f 
>   sentry-binding/sentry-binding-hive/src/test/java/org/apache/sentry/binding/hive/TestHiveAuthzBindingHook.java PRE-CREATION 
>   sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestUriPermissions.java 7fd2470 
> 
> Diff: https://reviews.apache.org/r/18911/diff/
> 
> 
> Testing
> -------
> 
> Adds new unit tests for this specific section of code in addition to new integration tests.
> 
> 
> Thanks,
> 
> Brock Noland
> 
>