You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "panbingkun (via GitHub)" <gi...@apache.org> on 2024/03/15 12:26:17 UTC
[PR] [SPARK-47419][CONNECT] Move `log4j2-defaults.properties` to `common\utils` [spark]
panbingkun opened a new pull request, #45532:
URL: https://github.com/apache/spark/pull/45532
### What changes were proposed in this pull request?
The pr aims to move `log4j2-defaults.properties` from `core` to `common\utils`.
### Why are the changes needed?
- As the `Logging class` is moved from module `core` to `common\utils`, the corresponding file `log4j2-defaults.properties` should be moved as well.
- Fix bug, as follows:
Before:
<img width="721" alt="image" src="https://github.com/apache/spark/assets/15246973/a5448754-354f-401f-a656-0a96ce5fcef0">
After:
<img width="719" alt="image" src="https://github.com/apache/spark/assets/15246973/4f0c5994-0e99-48df-95aa-9119b91c8319">
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
- Manually test.
- Pass GA.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47419][CONNECT] Move `log4j2-defaults.properties` to `common\utils` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #45532:
URL: https://github.com/apache/spark/pull/45532#issuecomment-1999564246
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47419][CONNECT] Move `log4j2-defaults.properties` to `common\utils` [spark]
Posted by "panbingkun (via GitHub)" <gi...@apache.org>.
panbingkun commented on PR #45532:
URL: https://github.com/apache/spark/pull/45532#issuecomment-1999563489
I opened the file `spark-common-utils_2.13-4.0.0-SNAPSHOT.jar` with `JD-GUI` and the results are as follows:
<img width="1396" alt="image" src="https://github.com/apache/spark/assets/15246973/dba4ab8c-588c-484b-8a62-e0113094b850">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47419][CONNECT] Move `log4j2-defaults.properties` to `common/utils` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45532: [SPARK-47419][CONNECT] Move `log4j2-defaults.properties` to `common/utils`
URL: https://github.com/apache/spark/pull/45532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org