[GitHub] [druid] zachjsh commented on issue #11690: authorization by string based resource type instead of enum so that resource types are extensible

[GitBox <gi...@apache.org>]

zachjsh commented on issue #11690:
URL: https://github.com/apache/druid/issues/11690#issuecomment-919392504


   @clintropolis  this approach sounds great. One question, you noted that 
   
   ```
   This approach does provide some minor disruption for extension writers, as Resource.getType will now return a String instead of an enum, but in most cases this should be very simple to resolve.
   ```
   
   What disruption are you concerned about exactly; as far as I understand the Resource class is not extendable as of now, so are there are extensions that would be disrupted by this? Alternatively, we could add a new method with default implementation as taking the existing enum string.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org