[jira] [Commented] (MESOS-2487) Ensure protobuf "==" operator does not go out of sync with new protobuf fields

["Frank Scholten (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-2487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14608096#comment-14608096 ] 

Frank Scholten commented on MESOS-2487:
---------------------------------------

I just filed https://issues.apache.org/jira/browse/MESOS-2960, started looking at the code and saw this issue mentioned in type_utils.cpp

I'm quite new to the Mesos code base so I might overlook things but perhaps custom protobuf options be used to designate essential values for equality checks?  


> Ensure protobuf "==" operator does not go out of sync with new protobuf fields
> ------------------------------------------------------------------------------
>
>                 Key: MESOS-2487
>                 URL: https://issues.apache.org/jira/browse/MESOS-2487
>             Project: Mesos
>          Issue Type: Task
>            Reporter: Vinod Kone
>
> Currently when a new field is added to a protobuf that has a custom "==" operator defined,  we don't make sure that the field is accounted for in the comparison. Ideally we should catch such errors at build time or 'make check' time. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)