You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2017/05/15 19:13:23 UTC

Review Request 59285: Disabled support for hierarchical roles.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59285/
-----------------------------------------------------------

Review request for mesos and Michael Park.


Repository: mesos


Description
-------

The previous plan was to include support for hierarchical roles in Mesos
1.3.0 but to mark it as experimental. Upon reflection, it seems safer to
disable hierarchical roles in Mesos 1.3.0, and address the open issues
during the 1.4 development process.


Diffs
-----

  src/common/roles.cpp 123e99073f8acbf4eb50e257e349e5485fba1cc6 
  src/tests/master_allocator_tests.cpp 3b072b251275e0cdfee3c40feebf78c6ad3a79d7 
  src/tests/role_tests.cpp 56422b507a0863ac1d9395eee63820291c2a4df5 


Diff: https://reviews.apache.org/r/59285/diff/1/


Testing
-------

`make check`


Thanks,

Neil Conway

Re: Review Request 59285: Disabled support for hierarchical roles.

Posted by Michael Park <mp...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59285/#review175155
-----------------------------------------------------------


Ship it!




Ship It!

- Michael Park


On May 15, 2017, 12:13 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59285/
> -----------------------------------------------------------
> 
> (Updated May 15, 2017, 12:13 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The previous plan was to include support for hierarchical roles in Mesos
> 1.3.0 but to mark it as experimental. Upon reflection, it seems safer to
> disable hierarchical roles in Mesos 1.3.0, and address the open issues
> during the 1.4 development process.
> 
> 
> Diffs
> -----
> 
>   src/common/roles.cpp 123e99073f8acbf4eb50e257e349e5485fba1cc6 
>   src/tests/master_allocator_tests.cpp 3b072b251275e0cdfee3c40feebf78c6ad3a79d7 
>   src/tests/role_tests.cpp 56422b507a0863ac1d9395eee63820291c2a4df5 
> 
> 
> Diff: https://reviews.apache.org/r/59285/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Neil Conway
> 
>