You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/05/31 14:30:38 UTC

[GitHub] [pulsar] coderzc opened a new pull request, #15863: Fix avro conversion order of registration

coderzc opened a new pull request, #15863:
URL: https://github.com/apache/pulsar/pull/15863

   <!--
   
   ### Motivation
   
   Fixes #15858 
   
   ### Modifications
   
   Fix avro conversion order of registration.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified
   
   ### Documentation
   
   Check the box below or label this PR directly.
   
   Need to update docs? 
   
   - [ ] `doc-required` 
   (Your PR needs to update docs and you will update later)
     
   - [x] `doc-not-needed` 
   (Please explain why)
     
   - [ ] `doc` 
   (Your PR contains doc changes)
   
   - [ ] `doc-complete`
   (Docs have been already added)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] coderzc commented on pull request #15863: [fix][client] Fix conversion of `TimestampMillisConversion` has no effect when Jsr310Conversion enabled

Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #15863:
URL: https://github.com/apache/pulsar/pull/15863#issuecomment-1142266520

   > good work! can you change the title explaining the issue ? `improve avro conversion order of registration` seems an improvement and it doesn't talk about the timestamp problem
   
   ok, I changed the title


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] fmiguelez commented on pull request #15863: [fix][client] Fix conversion of `TimestampMillisConversion` has no effect when Jsr310Conversion enabled

Posted by GitBox <gi...@apache.org>.
fmiguelez commented on PR #15863:
URL: https://github.com/apache/pulsar/pull/15863#issuecomment-1143339481

   It would be great to see this fix also applied to at least 2.9.x and 2.8.x branches. Is 2.7.x no longer supported?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] codelipenghui merged pull request #15863: [fix][client] Fix conversion of `TimestampMillisConversion` has no effect when Jsr310Conversion enabled

Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #15863:
URL: https://github.com/apache/pulsar/pull/15863


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org