You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/12/30 13:44:15 UTC

[GitHub] [spark] steveloughran commented on pull request #34895: [SPARK-6305][BUILD] Migrate from log4j1 to log4j2

steveloughran commented on pull request #34895:
URL: https://github.com/apache/spark/pull/34895#issuecomment-1003035050


   Pretty bold timing. I would have expected databricks builds to simply ship with a patched version of log4j 1.17, as we do https://mvnrepository.com/artifact/log4j/log4j/1.2.17-cloudera1
   
   Given all projects using log4j 2.x have had to do three emergency releases in the space of the week, you are potentially adding more work in the immediate future.
   
   * important* have you made sure any/ all transit to dependencies of log4j 1.x have been excluded, including its SLF4J binding class


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org