You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/06/22 04:37:29 UTC

[GitHub] [logging-log4j2] NgSekLong opened a new pull request #527: (doc) Add TimeBasedTriggeringPolicy, modulate default value to doc

NgSekLong opened a new pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527


   (doc)
   
   **TimeBasedTriggeringPolicy** modulate default is `false` is not in the doc which might caused confusion. 
   
   Would like to suggest adding the default as false in the doc for clarity, cheers!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vy merged pull request #527: Add TimeBasedTriggeringPolicy#modulate default value to the manual

Posted by GitBox <gi...@apache.org>.
vy merged pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vy commented on pull request #527: Add TimeBasedTriggeringPolicy#modulate default value to the manual

Posted by GitBox <gi...@apache.org>.
vy commented on pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527#issuecomment-865649894


   Thanks for the improvement @NgSekLong! Keep them coming! (I will cherry-pick this onto `release-2.x` too.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vy merged pull request #527: Add TimeBasedTriggeringPolicy#modulate default value to the manual

Posted by GitBox <gi...@apache.org>.
vy merged pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [logging-log4j2] vy commented on pull request #527: Add TimeBasedTriggeringPolicy#modulate default value to the manual

Posted by GitBox <gi...@apache.org>.
vy commented on pull request #527:
URL: https://github.com/apache/logging-log4j2/pull/527#issuecomment-865649894


   Thanks for the improvement @NgSekLong! Keep them coming! (I will cherry-pick this onto `release-2.x` too.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org