[GitHub] [kafka] ijuma commented on a diff in pull request #12752: KAFKA-14303 Fix batch.size=0 in BuiltInPartitioner

[GitBox <gi...@apache.org>]

ijuma commented on code in PR #12752:
URL: https://github.com/apache/kafka/pull/12752#discussion_r996190731


##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/BuiltInPartitioner.java:
##########
@@ -56,6 +56,9 @@ public class BuiltInPartitioner {
     public BuiltInPartitioner(LogContext logContext, String topic, int stickyBatchSize) {
         this.log = logContext.logger(BuiltInPartitioner.class);
         this.topic = topic;
+        if (stickyBatchSize < 1) {
+            throw new IllegalArgumentException("stickyBatchSize must at least 1");

Review Comment:
   You should include the value of `stickyBatchSize` in the message.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org