[GitHub] [solr] cpoerschke commented on a diff in pull request #1958: [WIP] SOLR-16985 Upgrade Lucene to 9.8.0

["cpoerschke (via GitHub)" <gi...@apache.org>]

cpoerschke commented on code in PR #1958:
URL: https://github.com/apache/solr/pull/1958#discussion_r1340402317


##########
solr/core/src/java/org/apache/solr/schema/DenseVectorField.java:
##########
@@ -194,24 +193,24 @@ public void checkSchemaField(final SchemaField field) throws SolrException {
 
     switch (vectorEncoding) {
       case FLOAT32:
-        if (dimension > FloatVectorValues.MAX_DIMENSIONS) {
+        if (dimension > KnnVectorsFormat.DEFAULT_MAX_DIMENSIONS) {
           if (log.isWarnEnabled()) {
             log.warn(
                 "The vector dimension {} specified for field {} exceeds the current Lucene default max dimension of {}. It's un-tested territory, extra caution and benchmarks are recommended for production systems.",
                 dimension,
                 field.getName(),
-                FloatVectorValues.MAX_DIMENSIONS);
+                KnnVectorsFormat.DEFAULT_MAX_DIMENSIONS);
           }
         }
         break;
       case BYTE:
-        if (dimension > ByteVectorValues.MAX_DIMENSIONS) {
+        if (dimension > KnnVectorsFormat.DEFAULT_MAX_DIMENSIONS) {
           if (log.isWarnEnabled()) {
             log.warn(
                 "The vector dimension {} specified for field {} exceeds the current Lucene default max dimension of {}. It's un-tested territory, extra caution and benchmarks are recommended for production systems.",
                 dimension,
                 field.getName(),
-                ByteVectorValues.MAX_DIMENSIONS);
+                KnnVectorsFormat.DEFAULT_MAX_DIMENSIONS);

Review Comment:
   for reference: https://github.com/apache/lucene/pull/12436



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org