You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by Hang Chen <ch...@apache.org> on 2023/02/21 04:38:09 UTC
[VOTE] BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()
Hi, All
After a fascinating discussion, I would start the vote for BP-61.
We will replace the `ReferenceCountUtil.safeRelease()` with
`ReferenceCountUtil.release()`.
Please leave +1/-1 in this thread to join the vote. And feel free to
leave any concerns.
Thanks to you guys.
Best,
Hang
References:
- BP: https://github.com/apache/bookkeeper/issues/3792
- Discussion https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc
Re: [VOTE] BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()
Posted by steven lu <lu...@gmail.com>.
+1 (non-binding)
sorry,I seem to have misunderstood, I thought you reverted first, and then
proposed a replacement,
these PRs( #3796 <https://github.com/apache/bookkeeper/pull/3796> #3398
<https://github.com/apache/bookkeeper/pull/3398> ) is for different
branches.
steven lu <lu...@gmail.com> 于2023年3月6日周一 11:36写道：
> -1 (non-binding)
> for new BP-61 :
> 1) I think no need to revert 12 PRs to refactor the ByteBuf release method
> 2) Directly replace ReferenceCountUtil.safeRelease() with
> ReferenceCountUtil.release()
>
>
> Hang Chen <ch...@apache.org> 于2023年2月21日周二 12:38写道：
>
>> Hi, All
>>
>> After a fascinating discussion, I would start the vote for BP-61.
>>
>> We will replace the `ReferenceCountUtil.safeRelease()` with
>> `ReferenceCountUtil.release()`.
>>
>> Please leave +1/-1 in this thread to join the vote. And feel free to
>> leave any concerns.
>>
>> Thanks to you guys.
>>
>> Best,
>> Hang
>>
>> References:
>> - BP: https://github.com/apache/bookkeeper/issues/3792
>> - Discussion
>> https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc
>>
>
Re: [VOTE] BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()
Posted by steven lu <lu...@gmail.com>.
-1 (non-binding)
for new BP-61 :
1) I think no need to revert 12 PRs to refactor the ByteBuf release method
2) Directly replace ReferenceCountUtil.safeRelease() with
ReferenceCountUtil.release()
Hang Chen <ch...@apache.org> 于2023年2月21日周二 12:38写道：
> Hi, All
>
> After a fascinating discussion, I would start the vote for BP-61.
>
> We will replace the `ReferenceCountUtil.safeRelease()` with
> `ReferenceCountUtil.release()`.
>
> Please leave +1/-1 in this thread to join the vote. And feel free to
> leave any concerns.
>
> Thanks to you guys.
>
> Best,
> Hang
>
> References:
> - BP: https://github.com/apache/bookkeeper/issues/3792
> - Discussion
> https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc
>
Re: [VOTE] BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()
Posted by Yong Zhang <zh...@gmail.com>.
+1 (non-binding)
Yong
On Wed, 22 Feb 2023 at 23:16, Jia Zhai <zh...@apache.org> wrote:
> +1
>
> On Wed, Feb 22, 2023 at 4:52 PM Enrico Olivelli <eo...@gmail.com>
> wrote:
>
> > +1 (binding)
> >
> > Enrico
> >
> > Il giorno mar 21 feb 2023 alle ore 05:38 Hang Chen
> > <ch...@apache.org> ha scritto:
> > >
> > > Hi, All
> > >
> > > After a fascinating discussion, I would start the vote for BP-61.
> > >
> > > We will replace the `ReferenceCountUtil.safeRelease()` with
> > > `ReferenceCountUtil.release()`.
> > >
> > > Please leave +1/-1 in this thread to join the vote. And feel free to
> > > leave any concerns.
> > >
> > > Thanks to you guys.
> > >
> > > Best,
> > > Hang
> > >
> > > References:
> > > - BP: https://github.com/apache/bookkeeper/issues/3792
> > > - Discussion
> > https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc
> >
>
Re: [VOTE] BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()
Posted by Jia Zhai <zh...@apache.org>.
+1
On Wed, Feb 22, 2023 at 4:52 PM Enrico Olivelli <eo...@gmail.com> wrote:
> +1 (binding)
>
> Enrico
>
> Il giorno mar 21 feb 2023 alle ore 05:38 Hang Chen
> <ch...@apache.org> ha scritto:
> >
> > Hi, All
> >
> > After a fascinating discussion, I would start the vote for BP-61.
> >
> > We will replace the `ReferenceCountUtil.safeRelease()` with
> > `ReferenceCountUtil.release()`.
> >
> > Please leave +1/-1 in this thread to join the vote. And feel free to
> > leave any concerns.
> >
> > Thanks to you guys.
> >
> > Best,
> > Hang
> >
> > References:
> > - BP: https://github.com/apache/bookkeeper/issues/3792
> > - Discussion
> https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc
>
Re: [VOTE] BP-61: Revert BP-59 to release ByteBuf using ReferenceCountUtil.release() instead of ReferenceCountUtil.safeRelease()
Posted by Enrico Olivelli <eo...@gmail.com>.
+1 (binding)
Enrico
Il giorno mar 21 feb 2023 alle ore 05:38 Hang Chen
<ch...@apache.org> ha scritto:
>
> Hi, All
>
> After a fascinating discussion, I would start the vote for BP-61.
>
> We will replace the `ReferenceCountUtil.safeRelease()` with
> `ReferenceCountUtil.release()`.
>
> Please leave +1/-1 in this thread to join the vote. And feel free to
> leave any concerns.
>
> Thanks to you guys.
>
> Best,
> Hang
>
> References:
> - BP: https://github.com/apache/bookkeeper/issues/3792
> - Discussion https://lists.apache.org/thread/9h7v7hs1pfp74mmopqtl7w4z0tq5rqhc