[GitHub] [skywalking] hanahmily commented on issue #3822: Add "Apdex" to OAL

[GitBox <gi...@apache.org>]

hanahmily commented on issue #3822: Add "Apdex" to OAL
URL: https://github.com/apache/skywalking/issues/3822#issuecomment-553432632
 
 
   > the appdex threshold should based on dynamic configuration.
   Why not use `oal` file to accomplish this goal. just like:
   ```
   // the threshold of service xxx is 500ms.
   service_xxx_apdex = from(Service.latency).filter(name==xxx).apdex(500);
   ```
   There's still some issues that should be addressed. The default "T", we can't set a default threshold for services, unless we calculate some apedx score more than once. For example:
   ```
   // the default thredhold of service is 500ms.
   service_apdex = from(Service.latency).apdex(500);
   // the thredhold of service xxx is 200ms. but there's a default apdex score for this service.
   service_xxx_apdex = from(Service.latency).filter(name==xxx).apdex(200);
   ```
   
   Finally, Why I suggest on OAL? Because this requirement belongs to its scope, and I don't want to add config file for it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services