You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "paolovolpi (via GitHub)" <gi...@apache.org> on 2025/07/09 07:19:09 UTC
[PR] arch/arm/rp23xx: spi unset peripheral before to modify Spi parameters [nuttx]
paolovolpi opened a new pull request, #16704:
URL: https://github.com/apache/nuttx/pull/16704
As done by Pico Sdk is be better to unset SSPCR1.SSE bit before to modify Spi parameters (Mode, Frequency and Bits).
*Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
*Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.*
## Impact
*Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.*
## Testing
*Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/rp23xx: spi unset peripheral before to modify Spi parameters [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #16704:
URL: https://github.com/apache/nuttx/pull/16704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/rp23xx: spi unset peripheral before to modify Spi parameters [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #16704:
URL: https://github.com/apache/nuttx/pull/16704#issuecomment-3057902578
@paolovolpi please don't use merge, use rebase instead. The steps to squash the commits are explained here:
https://nuttx.apache.org/docs/latest/contributing/making-changes.html#how-to-include-the-suggestions-on-your-pull-request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/rp23xx: spi unset peripheral before to modify Spi parameters [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #16704:
URL: https://github.com/apache/nuttx/pull/16704#issuecomment-3052875740
@paolovolpi please drop merge patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] arch/arm/rp23xx: spi unset peripheral before to modify Spi parameters [nuttx]
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #16704:
URL: https://github.com/apache/nuttx/pull/16704#issuecomment-3066219091
@paolovolpi nice work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org