You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/15 07:54:52 UTC

[GitHub] [pulsar] RobertIndie commented on a change in pull request #14287: [pulsar-client] fix: close dead producer and retry producer

RobertIndie commented on a change in pull request #14287:
URL: https://github.com/apache/pulsar/pull/14287#discussion_r806542682



##########
File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
##########
@@ -1008,6 +1008,20 @@ public void connectionFailed(PulsarClientException exception) {
 
         closeConsumerTasks();
 
+        if (this.deadLetterProducer != null) {
+            try {
+                deadLetterProducer.get().closeAsync();

Review comment:
       Please use asynchronous calls here and make it to be connected to `closeFuture`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org