You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2022/10/12 11:40:43 UTC

[GitHub] [ignite-3] rpuch opened a new pull request, #1194: IGNITE-17254 Storage API for RAFT snapshot streaming

rpuch opened a new pull request, #1194:
URL: https://github.com/apache/ignite-3/pull/1194

   https://issues.apache.org/jira/browse/IGNITE-17254


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ignite-3] SammyVimes merged pull request #1194: IGNITE-17254 Storage API for RAFT snapshot streaming

Posted by GitBox <gi...@apache.org>.
SammyVimes merged PR #1194:
URL: https://github.com/apache/ignite-3/pull/1194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [ignite-3] SammyVimes commented on a diff in pull request #1194: IGNITE-17254 Storage API for RAFT snapshot streaming

Posted by GitBox <gi...@apache.org>.
SammyVimes commented on code in PR #1194:
URL: https://github.com/apache/ignite-3/pull/1194#discussion_r994478467


##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/ReadResult.java:
##########
@@ -45,13 +45,26 @@ public class ReadResult {
     private final int commitPartitionId;
 
     /**
-     * Timestamp of the newest commit of the data. Not {@code null} iff committed version exists, this is a
+     * Commit timestamp of this version (of exists). Non-null for committed versions, {@code null} for write intents.

Review Comment:
   ```suggestion
        * Commit timestamp of this version (if exists). Non-null for committed versions, {@code null} for write intents.
   ```



##########
modules/storage-page-memory/src/main/java/org/apache/ignite/internal/storage/pagememory/mv/AbstractPageMemoryMvPartitionStorage.java:
##########
@@ -627,7 +630,35 @@ private void updateVersionChain(VersionChain newVersionChain) {
     }
 
     @Override
-    public Cursor<BinaryRow> scanVersions(RowId rowId) throws StorageException {
+    public void addWriteCommitted(RowId rowId, BinaryRow row, HybridTimestamp commitTimestamp) throws StorageException {
+        assert rowId.partitionId() == partitionId : rowId;
+
+        VersionChain currentChain = findVersionChain(rowId);
+
+        if (currentChain != null && currentChain.isUncommitted()) {
+            throw new StorageException("Write intent exists for " + rowId);

Review Comment:
   Please add a comment clarifying that it's more of a fail-fast bug prevention



##########
modules/storage-rocksdb/src/test/java/org/apache/ignite/internal/storage/rocksdb/RocksDbMvPartitionStorageTest.java:
##########
@@ -78,4 +78,9 @@ public void tearDown() throws Exception {
                 engine == null ? null : engine::stop
         );
     }
+
+    @Override
+    public void addWriteCommittedThrowsIfUncommittedVersionExists() {
+        // Disable this test because RocksDbMvPartitionStorage does not throw

Review Comment:
   Also would be nice to clarify here why rocksdb doesn't throw



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org