You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "gaoyunhaii (via GitHub)" <gi...@apache.org> on 2023/02/09 04:56:09 UTC

[GitHub] [flink-ml] gaoyunhaii commented on pull request #206: [FLINK-30933] Fix missing max watermark when executing join in iteration body

gaoyunhaii commented on PR #206:
URL: https://github.com/apache/flink-ml/pull/206#issuecomment-1423633492

   As a whole LGTM, and @zhipeng93 could you modify the test to also check the max watermark is indeed emitted before termination?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org