[GitHub] [kafka] cmccabe commented on a diff in pull request #13532: KAFKA-14887: No shutdown for ZK session expiration in feature processing

["cmccabe (via GitHub)" <gi...@apache.org>]

cmccabe commented on code in PR #13532:
URL: https://github.com/apache/kafka/pull/13532#discussion_r1171947569


##########
core/src/main/scala/kafka/server/FinalizedFeatureChangeListener.scala:
##########
@@ -160,10 +160,12 @@ class FinalizedFeatureChangeListener(private val finalizedFeatureCache: ZkMetada
           // safe to ignore the exception if the thread is being shutdown. We raise the exception
           // here again, because, it is ignored by ShutdownableThread if it is shutting down.
           throw ie
-        case e: Exception => {
-          error("Failed to process feature ZK node change event. The broker will eventually exit.", e)
+        case cacheUpdateException: FeatureCacheUpdateException =>

Review Comment:
   It's tough to decide what to do in the case where we hit a feature notification and we can't understand it. This is something we can discuss in a follow-on PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org