[GitHub] [spark] ueshin commented on a diff in pull request #40725: [SPARK-43082][CONNECT][PYTHON] Arrow-optimized Python UDFs in Spark Connect

["ueshin (via GitHub)" <gi...@apache.org>]

ueshin commented on code in PR #40725:
URL: https://github.com/apache/spark/pull/40725#discussion_r1172924368


##########
python/pyspark/sql/tests/connect/test_parity_arrow_python_udf.py:
##########
@@ -0,0 +1,46 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+import unittest
+
+from pyspark.sql.tests.connect.test_parity_udf import UDFParityTests
+from pyspark.sql.tests.test_arrow_python_udf import PythonUDFArrowTestsMixin
+
+
+class ArrowPythonUDFParityTests(UDFParityTests, PythonUDFArrowTestsMixin):
+    @classmethod
+    def setUpClass(cls):
+        super(ArrowPythonUDFParityTests, cls).setUpClass()
+        cls.spark.conf.set("spark.sql.execution.pythonUDF.arrow.enabled", "true")
+
+    @classmethod
+    def tearDownClass(cls):
+        cls.spark.conf.unset("spark.sql.execution.pythonUDF.arrow.enabled")
+        super(ArrowPythonUDFParityTests, cls).tearDownClass()

Review Comment:
   Let's make sure `super().tearDownClass()` will always be called.
   
   ```suggestion
           try:
               cls.spark.conf.unset("spark.sql.execution.pythonUDF.arrow.enabled")
           finally:
               super(ArrowPythonUDFParityTests, cls).tearDownClass()
   ```



##########
python/pyspark/sql/tests/test_arrow_python_udf.py:
##########
@@ -118,6 +113,18 @@ def test_use_arrow(self):
         self.assertEquals(row_false[0], "[1, 2, 3]")
 
 
+class PythonUDFArrowTests(PythonUDFArrowTestsMixin, ReusedSQLTestCase):
+    @classmethod
+    def setUpClass(cls):
+        super(PythonUDFArrowTests, cls).setUpClass()
+        cls.spark.conf.set("spark.sql.execution.pythonUDF.arrow.enabled", "true")
+
+    @classmethod
+    def tearDownClass(cls):
+        cls.spark.conf.unset("spark.sql.execution.pythonUDF.arrow.enabled")
+        super().tearDownClass()

Review Comment:
   ditto.
   
   ```suggestion
           try:
               cls.spark.conf.unset("spark.sql.execution.pythonUDF.arrow.enabled")
           finally:
               super().tearDownClass()
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org