You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/03/15 09:25:40 UTC
[GitHub] [apisix-dashboard] batman-ezio opened a new issue #1595: What is the he Unique identifier of a route (name or id)?
batman-ezio opened a new issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595
# Feature request
## Please describe your feature
follow this guide to https://github.com/apache/apisix/blob/master/docs/en/latest/getting-started.md
to create a test route , the final route is
```
{
"action": "get",
"node": {
"value": {
"plugins": {
"proxy-rewrite": {
"scheme": "https",
"regex_uri": ["^\/samplePrefix\/get(.*)", "\/get$1"]
},
"key-auth": {}
},
"id": "5",
"uri": "\/samplePrefix\/get",
"update_time": 1615794114,
"status": 1,
"upstream_id": 50,
"priority": 0,
"create_time": 1615793637
},
"key": "\/apisix\/routes\/5"
},
"count": "1"
}
```
The id field is `id` which is 5 here,
but when I open `dashboard`, it use `name` as a required and primary key. and there's no place to display `id` in the UI.
User can not go to the next step in the edit mode to see all the data


## Describe the solution you'd like
## add default name
change logic in the PUT route api, set a default name from the url params
## display id field in List. Edit route view to
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-800025632
> @batman-ezio thanks for reporting and it's a bug actually.
>
> IMHO this bug is caused by the route name is considered as a mandatory field when creating a route from Dashboard, while it's optional via APISIX Admin API.
>
> How about allow the same route name and show the ID in WebUI, which is the unique key ?
>
> @nic-chen @liuxiran Any insights on this?
I think name of resource should be a mandatory field, there is no reason to use the same name for different routes or services.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-1002388618
> > Oh btw, we have a meeting today, welcome to join in if you have time 😄 see [apache/apisix#5721](https://github.com/apache/apisix/discussions/5721)
>
> So regretful missing the meeting, I was delayed by other things.
Oh it doesn't matter, today we have the meeting at 20:00 PM, see https://docs.qq.com/doc/DTkd3a2RraXBCaklm (Chinese Version)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] mangoGoForward edited a comment on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
Posted by GitBox <gi...@apache.org>.
mangoGoForward edited a comment on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-985602446
I'd like to work on this issue, pls assign to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey edited a comment on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
imjoey edited a comment on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-800010594
@batman-ezio thanks for reporting and it's a bug actually.
IMHO this bug is caused by the route name is considered as a mandatory field when creating a route from Dashboard, while it's optional via APISIX Admin API.
How about allow the same route name and show the ID in WebUI, which is the unique key ?
@nic-chen @liuxiran Any insights on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-801464702
> @imjoey agree
> but for the better FE, can we add id file and display in the LIST view?
> when user can route by admin api Put `/route/a1` and `route/a2` and so on.
> they can easily find their routes by looking up the id field
>
> @nic-chen @liuxiran
Agree with you to display the `id` field in the list view which is already returned by `/apisix/admin/routes` in manager-api
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-799293593
@batman-ezio Unique identifier of a route is ID.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-800959376
> @imjoey agree
> but for the better FE, can we add id file and display in the LIST view?
> when user can route by admin api Put `/route/a1` and `route/a2` and so on.
> they can easily find their routes by looking up the id field
>
> @nic-chen @liuxiran
I think it's OK for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
batman-ezio commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-799981665
how about display the id field in route and upstream list view ? @nic-chen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-801716090
> @imjoey agree
> but for the better FE, can we add id file and display in the LIST view?
> when user can route by admin api Put `/route/a1` and `route/a2` and so on.
> they can easily find their routes by looking up the id field
>
> @nic-chen @liuxiran
@batman-ezio agreed +1 for show route ID on LIST and EDIT pages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-988460587
Oh btw, we have a meeting today, welcome to join in if you have time 😄 see https://github.com/apache/apisix/discussions/5721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] mangoGoForward commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-1002367848
> Oh btw, we have a meeting today, welcome to join in if you have time 😄 see [apache/apisix#5721](https://github.com/apache/apisix/discussions/5721)
So regretful missing the meeting, I was delayed by other things.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-800043583
> Fe focuses on the user experience, `name` is better to distinguish a route, so we set `name` as a required key.
> while API focuses on the feature, `name` is not the key field, so it is not reqired in admin-api, that is also reasonable IMHO
> so, how about just keep the current UE in dashboard, when user create a route without a name by admin-api, they have to set the `name` in dashboard page.
@nic-chen @liuxiran agreed +1 for keeping this still.
@batman-ezio What do you think? Looking forward to your feedback. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] mangoGoForward commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
Posted by GitBox <gi...@apache.org>.
mangoGoForward commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-985602446
I'd like to work on this issue, pls assign to me.
/assign
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] mangoGoForward edited a comment on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
Posted by GitBox <gi...@apache.org>.
mangoGoForward edited a comment on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-985602446
I'd like to work on this issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-800038539
Fe focuses on the user experience, `name` is better to distinguish a route, so we set `name` as a required key.
while API focuses on the feature, `name` is not the key field, so it is not reqired in admin-api, that is also reasonable IMHO
so, how about just keep the current UE in dashboard, when user create a route without a name by admin-api, they have to set the `name` in dashboard page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
imjoey commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-800010594
@batman-ezio thanks for reporting and it's a bug actually.
IMHO this bug is caused by the route name is considered as a mandatory field when creating a route from Dashboard, while it's optional via APISIX Admin API. @nic-chen @liuxiran Any insights on this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on issue #1595: What is the he Unique identifier of a route (name or id)?
Posted by GitBox <gi...@apache.org>.
batman-ezio commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-800873300
@imjoey agree
but for the better FE, can we add id file and display in the LIST view?
when user can route by admin api Put `/route/a1` and `route/a2` and so on.
they can easily find their routes by looking up the id field
@nic-chen @liuxiran
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1595: feat: Show route ID at LIST and EDIT views in dashboard
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #1595:
URL: https://github.com/apache/apisix-dashboard/issues/1595#issuecomment-988460167
Hi @mangoGoForward, you could do it if no PR linked to this issue 😄 If I'm late to reply you, just @ me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org