[GitHub] [geode] echobravopapa opened a new pull request #5706: GEODE-8681: peer-to-peer message loss due to sending connection closi…

[GitBox <gi...@apache.org>]

echobravopapa opened a new pull request #5706:
URL: https://github.com/apache/geode/pull/5706


   …ng with TLS enabled (#5699)
   
   A socket-read could pick up more than one message and a single unwrap()
   could decrypt multiple messages.
   Normally the engine isn't closed and it reports normal
   status from an unwrap() operation, and Connection.processInputBuffer
   picks up each message, one by one, from the buffer and dispatches them.
   But if the SSLEngine is closed we were ignoring any already-decrypted
   data sitting in the unwrapped buffer and instead we were throwing an SSLException.
   
   (cherry picked from commit 7da8f9b516ac1e2525a1dfc922af7bfb8995f2c6)
   (cherry picked from commit 03bbc2ac54998cbb015d533e4fe6e75b3e973146)
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] echobravopapa closed pull request #5706: GEODE-8681: peer-to-peer message loss due to sending connection closi…

[GitBox <gi...@apache.org>]

echobravopapa closed pull request #5706:
URL: https://github.com/apache/geode/pull/5706


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org