You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <br...@users.sf.net> on 2014/08/19 22:03:53 UTC

[allura:tickets] #7628 test_filtering fails occasionally



---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** in-progress
**Milestone:** forge-aug-22
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Tue Aug 19, 2014 08:03 PM UTC
**Owner:** Dave Brondsema

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7628 test_filtering fails occasionally

Posted by Dave Brondsema <br...@users.sf.net>.
- **QA**: Dave Brondsema



---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** code-review
**Milestone:** forge-sep-5
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Wed Sep 03, 2014 02:01 PM UTC
**Owner:** Igor Bondarenko

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7628 test_filtering fails occasionally

Posted by Dave Brondsema <br...@users.sf.net>.
- **Milestone**: forge-aug-22 --> forge-sep-5



---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** open
**Milestone:** forge-sep-5
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Fri Aug 22, 2014 05:50 PM UTC
**Owner:** nobody

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7628 test_filtering fails occasionally

Posted by Dave Brondsema <br...@users.sf.net>.
- **status**: in-progress --> open
- **assigned_to**: Dave Brondsema -->  nobody 
- **Milestone**: forge-sep-5 --> forge-aug-22



---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** open
**Milestone:** forge-aug-22
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Fri Aug 22, 2014 04:22 PM UTC
**Owner:** nobody

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7628 test_filtering fails occasionally NEEDS CMD

Posted by Dave Brondsema <br...@users.sf.net>.
- **summary**: test_filtering fails occasionally --> test_filtering fails occasionally NEEDS CMD
- **status**: code-review --> closed
- **Comment**:

Command to run to clean up duplicate trove records:

`paster script development.ini allura/scripts/remove_duplicate_troves.py -- --dry-run` and watch log file for results.  Then run without `--dry-run`



---

** [tickets:#7628] test_filtering fails occasionally NEEDS CMD**

**Status:** closed
**Milestone:** forge-sep-5
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Tue Sep 09, 2014 02:34 PM UTC
**Owner:** Igor Bondarenko

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7628 test_filtering fails occasionally

Posted by Igor Bondarenko <je...@users.sf.net>.
- **status**: in-progress --> code-review



---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** code-review
**Milestone:** forge-sep-5
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Wed Sep 03, 2014 01:59 PM UTC
**Owner:** Igor Bondarenko

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7628 test_filtering fails occasionally

Posted by Igor Bondarenko <je...@users.sf.net>.
- **status**: open --> in-progress
- **assigned_to**: Igor Bondarenko



---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** in-progress
**Milestone:** forge-sep-5
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Mon Aug 25, 2014 07:48 PM UTC
**Owner:** Igor Bondarenko

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7628 test_filtering fails occasionally

Posted by Dave Brondsema <br...@users.sf.net>.
- **Milestone**: forge-aug-22 --> forge-sep-5



---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** in-progress
**Milestone:** forge-sep-5
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Wed Aug 20, 2014 06:51 AM UTC
**Owner:** Dave Brondsema

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7628 test_filtering fails occasionally

Posted by Igor Bondarenko <je...@users.sf.net>.
Yes, it seems like `m__add_agpl_and_lppl` duplicates categories that already created in main method. I remember that in [#6848] I've compared dumps of all categories generated with old command + migration and generated with new command and they was identical. As you can see from the commits below, there were already duplicates in old command + migration scripts (`014-add-trove-category-agpl.py`, `016-add-trove-category-lppl.py`)

`git show 350faaae13433e34f3b161aa9beacdf7ee933f0a`
`git show 77fb5d8c3788ee3d7fa5133354ca38213c8cedb5`

It seems to me that `m__add_agpl_and_lppl` can be removed to avoid duplicates (but probably need a script to remove duplicates from mongo instances where categories were already created)


---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** in-progress
**Milestone:** forge-aug-22
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Tue Aug 19, 2014 08:03 PM UTC
**Owner:** Dave Brondsema

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.

[allura:tickets] #7628 test_filtering fails occasionally

Posted by Igor Bondarenko <je...@users.sf.net>.
Closed #646. ``

To reproduce test failure on master you can change it like this (it still might not fail, but after 5-6 runs usually does):

{{{
     # set up for test
     from random import choice
     setup_trove_categories()
-    random_trove = choice(M.TroveCategory.query.find().all())
+    random_trove = choice(M.TroveCategory.query.find({'shortname': 'lppl'}).all())
}}}

Make sure that it is not failing on a branch (with given change).

Also, created a script to remove duplicates if they present in db. It's a bit tricky, so make sure you run it with `--dry-run` first, to understand what will be done. Unfortunately, re-running `create_trove_categories` to re-generate categories will remove categories from all existing projects (since all categories would get new ids), so we need that script.

Actually, I don't sure why project -> category relationship depends on `ObjectId`s, when  categories have a natural unique id (cat_id + parent_id). Maybe we need to refactor it someday. :)


---

** [tickets:#7628] test_filtering fails occasionally**

**Status:** in-progress
**Milestone:** forge-sep-5
**Created:** Tue Aug 19, 2014 08:03 PM UTC by Dave Brondsema
**Last Updated:** Fri Aug 29, 2014 07:44 AM UTC
**Owner:** Igor Bondarenko

`allura/tests/test_globals.py:test_filtering` fails sometimes.  It randomly picks a trove category to use for the test, and some trove categories are in the test data twice, so the lookup fails.  It seems that in `allura/command/create_trove_categories.py` the `m__add_agpl_and_lppl` method creates TroveCategories that already exist in the main `command` method.


---

Sent from sourceforge.net because dev@allura.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.