You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "soreana (via GitHub)" <gi...@apache.org> on 2023/07/26 15:09:21 UTC
[GitHub] [cloudstack] soreana opened a new issue, #7776: Passing domain id without an account ignored
soreana opened a new issue, #7776:
URL: https://github.com/apache/cloudstack/issues/7776
<!--
Verify first that your issue/request is not already reported on GitHub.
Also test if the latest release and main branch are affected too.
Always add information AFTER of these HTML comments, but no need to delete the comments.
-->
##### ISSUE TYPE
<!-- Pick one below and delete the rest -->
* Bug Report
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
API
~~~
##### CLOUDSTACK VERSION
<!--
New line separated list of affected versions, commit ID for issues on main branch.
-->
~~~
4.17, 4.18, main, and probably most of the previous versions
~~~
##### SUMMARY
<!-- Explain the problem/feature briefly -->
When the API calls are made using only the `domainid` parameter, CloudStack currently ignores it. For instance, in the `createNetwork` api call, there is an option to pass both domainid and account parameters. All combinations of `domainid` and `account` in the following table make sense except for the second combination. As a user, I would expect that the network should be created under the specified domain or receive an error message stating that I need to provide an account as well. However, nowhere in the API documentation does it mention that an account must be provided when calling createNetwork with a specific domainid.
| idx | domainid parameter is in API call | account parameter is in API call | result |
|---|--------|--------|--------|
| 1 | yes | yes | network created under the account and domain |
| 2 | yes | NO | network created under the caller domain and account |
| 3 | NO | yes | network creation failed |
| 4 | NO | NO | network created under the caller domain and account |
##### STEPS TO REPRODUCE
<!--
For bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.
For new features, show how the feature would be used.
-->
<!-- Paste example playbooks or commands between quotes below -->
Run the following command to create a network (type of network doesn't matter, I also checked the deploy virtual machine it is the same behaviour)
```
(localcloud) > create network domainid=<domain id> name=L2-withou-account displaytext=L2-without-account zoneid=<zone id> networkofferingid=<offering id>
{
"network": {
"account": "admin",
"acltype": "Account",
...
"domain": "ROOT",
"domainid": "2ddf37db-1fc3-11ee-a012-1e00cf003378",
}
}
```
<!-- You can also paste gist.github.com links for larger files -->
##### EXPECTED RESULTS
<!-- What did you expect to happen when running the steps above? -->
~~~
CloudStack throws an error or creates the network under the correct domain
~~~
##### ACTUAL RESULTS
<!-- What actually happened? -->
<!-- Paste verbatim command output between quotes below -->
~~~
Network created under the root domain.
~~~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7776: Passing domain id without an account ignored
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1653057263
> @DaanHoogland yes error can be thrown, I think this is a design thought. Last time I just logged a message, didn't want to break the backward compatibility.
>
> https://github.com/apache/cloudstack/blob/41bbedb530e2e94016525adc67e6642cb48ef2c8/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L1405-L1406
that message is an info in case "either projectId or accountname and domainId are not provided". I think we can split between that case and when `domainid` *is* provided but `projectId or accountname` are not. This is a minor issue, but it makes sense to return an error in those cases. (if we all agree!)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7776: Passing domain id without an account ignored
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1653070711
> > @DaanHoogland yes error can be thrown, I think this is a design thought. Last time I just logged a message, didn't want to break the backward compatibility.
> > https://github.com/apache/cloudstack/blob/41bbedb530e2e94016525adc67e6642cb48ef2c8/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L1405-L1406
>
> that message is an info in case "either projectId or accountname and domainId are not provided". I think we can split between that case and when `domainid` _is_ provided but `projectId or accountname` are not. This is a minor issue, but it makes sense to return an error in those cases. (if we all agree!)
@DaanHoogland
yes, thrown an error message if
- acltype is Account, and
- domainid is passed, and
- account name and projectid are not passed
in my opinion, there will be more trouble than benefit.
(the behaviour has existed for many years)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on issue #7776: Passing domain id without an account ignored
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1654910378
In a way I agree with both @soreana and @weizhouapache as this is a valid concern but fixing this may raise immediate issues with the existing environments.
May be we can do below things
1. Fix API parameters descriptions
2. Make account selection mandatory when domain is selected.
I'm not sure how hard is to make point 2 working in UI, if that takes time we can go with point 1 only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7776: Passing domain id without an account ignored
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1652798626
@soreana
this is expected behavior, I think
To create a network for a domain , you need to pass acltype=Domain
refer to https://cloudstack.apache.org/api/apidocs-4.18/apis/createNetwork.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #7776: Passing domain id without an account ignored
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1680828170
> > @DaanHoogland That would be enough, I will take care of them.
>
> @soreana any update ?
I've created #7876 PR, let me know if other API calls needs to be added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7776: Passing domain id without an account ignored
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1653026186
@weizhouapache @harikrishna-patnala , @soreana states, 'or receive an error message stating that I need to provide an account as well.' Does this make sense to you?
If the user provides a domainid it is strange to create the network in another domain, even when only providing a domainid is not a valid parameter set. (imnsho)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #7776: Passing domain id without an account ignored
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1653822331
> > > ok, agree @soreana ?
> >
> >
> > @DaanHoogland Yeah, that is makes sense, CloudStack should throw an error when only the domain id is provided.
> > Btw, @DaanHoogland @harikrishna-patnala @weizhouapache the `createNetwork` API call was a tip of an ice burg, even if we make it works other API calls still have an issue, I've tested a few (`deployVirtualmachine`, `createSnapshot`, `createVolume` ) they are all have the same issue ...
> > ```
> > (localcloud) > deploy virtualmachine domainid=<domain id> networkids=<network id> serviceofferingid=<service offering id> templateid=<template id> zoneid=<zone id>
> > {
> > "virtualmachine": {
> > "account": "admin",
> > "domain": "ROOT",
> > "domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377",
> > ...
> > }
> > }
> > (localcloud) > create snapshot domainid=<domain id> volumeid=<volume id>
> > {
> > "snapshot": {
> > "account": "admin",
> > "domain": "ROOT",
> > "domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377",
> > ..
> > }
> > }
> > (localcloud) > create volume domainid=<domain id> snapshotid=<snapshot id>
> > {
> > "volume": {
> > "account": "admin",
> > "domain": "ROOT",
> > "domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377",
> > ...
> > }
> > }
> > ```
>
> @soreana yes I prefer not to change any of them. We do not know what the changes might cause. ui, cmk, users' scripts, terraform, etc
@weizhouapache Can We at least change the API documentations?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7776: Passing domain id without an account ignored
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1654857867
> @weizhouapache That is a valid concern. Can We at least change the API documentations?
@soreana
yes, we can change the description of API parameters, and UI. These have small impact.
Would you like to make the changes ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7776: Passing domain id without an account ignored
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1655207799
> > with the existing environments.
> > May be we can do below things
> >
> > 1. Fix API parameters descriptions
> > 2. Make account selection mandatory when domain is selected only in UI. API will continue to work as is.
> >
> > I'm not sure how hard is to make point 2 working in UI, if that takes time we can go with point 1 only.
>
> agree with @harikrishna-patnala
I am not so keen in making implementing functionality in the UI only. it creates an inconsistency for users and add a maintenance burdon on developers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7776: Passing domain id without an account ignored
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1665138692
so far I see the following for the create network API
```
@Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, entityType = DomainResponse.class, description = "domain ID of the account owning a network. " +
"If no account is provided then network will be assigned to the caller account and domain")
private Long domainId;
```
this looks like enough documentation to me. cc @soreana @harikrishna-patnala @weizhouapache
Are there other places I should look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #7776: Passing domain id without an account ignored
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1666022347
> so far I see the following for the create network API
>
> ```
> @Parameter(name = ApiConstants.DOMAIN_ID, type = CommandType.UUID, entityType = DomainResponse.class, description = "domain ID of the account owning a network. " +
> "If no account is provided then network will be assigned to the caller account and domain")
> private Long domainId;
> ```
>
> this looks like enough documentation to me. cc @soreana @harikrishna-patnala @weizhouapache
>
> Are there other places I should look?
@DaanHoogland That would be enough, I will take care of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7776: Passing domain id without an account ignored
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1676877174
> @DaanHoogland That would be enough, I will take care of them.
@soreana
any update ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7776: Passing domain id without an account ignored
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1653667060
> >
> > ok, agree @soreana ?
>
> @DaanHoogland Yeah, that is makes sense, CloudStack should throw an error when only the domain id is provided.
>
> Btw, @DaanHoogland @harikrishna-patnala @weizhouapache the `createNetwork` API call was a tip of an ice burg, even if we make it works other API calls still have an issue, I've tested a few (`deployVirtualmachine`, `createSnapshot`, `createVolume` ) they are all have the same issue ...
>
> ```
> (localcloud) > deploy virtualmachine domainid=<domain id> networkids=<network id> serviceofferingid=<service offering id> templateid=<template id> zoneid=<zone id>
> {
> "virtualmachine": {
> "account": "admin",
> "domain": "ROOT",
> "domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377",
> ...
> }
> }
> (localcloud) > create snapshot domainid=<domain id> volumeid=<volume id>
> {
> "snapshot": {
> "account": "admin",
> "domain": "ROOT",
> "domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377",
> ..
> }
> }
> (localcloud) > create volume domainid=<domain id> snapshotid=<snapshot id>
> {
> "volume": {
> "account": "admin",
> "domain": "ROOT",
> "domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377",
> ...
> }
> }
> ```
@soreana
yes
I prefer not to change any of them. We do not know what the changes might cause.
ui, cmk, users' scripts, terraform, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #7776: Passing domain id without an account ignored
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1685295224
Closing this issue as the https://github.com/apache/cloudstack/pull/7876 got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana closed issue #7776: Passing domain id without an account ignored
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana closed issue #7776: Passing domain id without an account ignored
URL: https://github.com/apache/cloudstack/issues/7776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on issue #7776: Passing domain id without an account ignored
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1652887469
Yes @soreana this is expected behaviour.
To keep the better visibility wrt to accounts, last time we have fixed the parameter descriptions (https://github.com/apache/cloudstack/pull/7387) and keep a drop down of accounts under the selected domain (https://github.com/apache/cloudstack/pull/7393) in 4.18.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on issue #7776: Passing domain id without an account ignored
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1653045440
@DaanHoogland yes error can be thrown, I think this is a design thought. Last time I just logged a message, didn't want to break the backward compatibility.
https://github.com/apache/cloudstack/blob/41bbedb530e2e94016525adc67e6642cb48ef2c8/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L1405-L1406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on issue #7776: Passing domain id without an account ignored
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1653153285
> > > @DaanHoogland yes error can be thrown, I think this is a design thought. Last time I just logged a message, didn't want to break the backward compatibility.
> > > https://github.com/apache/cloudstack/blob/41bbedb530e2e94016525adc67e6642cb48ef2c8/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L1405-L1406
> >
> >
> > that message is an info in case "either projectId or accountname and domainId are not provided". I think we can split between that case and when `domainid` _is_ provided but `projectId or accountname` are not. This is a minor issue, but it makes sense to return an error in those cases. (if we all agree!)
>
> @DaanHoogland yes, thrown an error message if
>
> * acltype is Account, and
>
> * domainid is passed, and
>
> * account name and projectid are not passed
>
>
> in my opinion, there will be more trouble than benefit. (the behaviour has existed for many years)
ok, agree @soreana ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on issue #7776: Passing domain id without an account ignored
Posted by "soreana (via GitHub)" <gi...@apache.org>.
soreana commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1653467025
> > > > @DaanHoogland yes error can be thrown, I think this is a design thought. Last time I just logged a message, didn't want to break the backward compatibility.
> > > > https://github.com/apache/cloudstack/blob/41bbedb530e2e94016525adc67e6642cb48ef2c8/server/src/main/java/com/cloud/network/NetworkServiceImpl.java#L1405-L1406
> > >
> > >
> > > that message is an info in case "either projectId or accountname and domainId are not provided". I think we can split between that case and when `domainid` _is_ provided but `projectId or accountname` are not. This is a minor issue, but it makes sense to return an error in those cases. (if we all agree!)
> >
> >
> > @DaanHoogland yes, thrown an error message if
> > ```
> > * acltype is Account, and
> >
> > * domainid is passed, and
> >
> > * account name and projectid are not passed
> > ```
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> >
> > in my opinion, there will be more trouble than benefit. (the behaviour has existed for many years)
>
> ok, agree @soreana ?
@DaanHoogland Yeah, that is makes sense, CloudStack should throw an error when only the domain id is provided.
Btw, @DaanHoogland @harikrishna-patnala @weizhouapache the `createNetwork` API call was a tip of an ice burg, even if we make it works other API calls still have an issue, I've tested a few (`deployVirtualmachine`, `createSnapshot`, `createVolume` ) they are all have the same issue ...
```
(localcloud) > deploy virtualmachine domainid=<domain id> networkids=<network id> serviceofferingid=<service offering id> templateid=<template id> zoneid=<zone id>
{
"virtualmachine": {
"account": "admin",
..
"domain": "ROOT",
"domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377",
...
}
}
(localcloud) > create snapshot domainid=<domain id> volumeid=<volume id>
{
"snapshot": {
"account": "admin",
"domain": "ROOT",
"domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377",
..
}
}
(localcloud) > create volume domainid=<domain id> snapshotid=<snapshot id>
{
"volume": {
"account": "admin",
...
"domain": "ROOT",
"domainid": "ea2dcd59-249f-11ee-bb7d-1e000d003377",
...
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on issue #7776: Passing domain id without an account ignored
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on issue #7776:
URL: https://github.com/apache/cloudstack/issues/7776#issuecomment-1654916822
> with the existing environments.
>
> May be we can do below things
>
> 1. Fix API parameters descriptions
> 2. Make account selection mandatory when domain is selected only in UI. API will continue to work as is.
>
> I'm not sure how hard is to make point 2 working in UI, if that takes time we can go with point 1 only.
agree with @harikrishna-patnala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org