You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by "Gary D. Gregory (Jira)" <ji...@apache.org> on 2023/10/20 12:57:00 UTC

[jira] [Resolved] (IO-816) UnsynchronizedBufferedInputStream.read(byte[], int, int) does not use buffer

     [ https://issues.apache.org/jira/browse/IO-816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory resolved IO-816.
--------------------------------
    Fix Version/s: 2.15.0
       Resolution: Fixed

[~anloth] 

Thank you for your report!

Fixed in git master. Please review and close if appropriate.

> UnsynchronizedBufferedInputStream.read(byte[], int, int) does not use buffer
> ----------------------------------------------------------------------------
>
>                 Key: IO-816
>                 URL: https://issues.apache.org/jira/browse/IO-816
>             Project: Commons IO
>          Issue Type: Bug
>            Reporter: Andreas Loth
>            Priority: Major
>             Fix For: 2.15.0
>
>
> Commit bdb9f8b9095004703666675591c3c3de30e7c03a renamed the field `buf` to `buffer`. This causes name shadowing in `UnsynchronizedBufferedInputStream.read(byte[], int, int)`: the field buffer is shadowed by the parameter `buffer`.
> I cannot see any usage of the field `buffer` in the whole method.
> Also the test class `UnsynchronizedBufferedInputStreamTest` seems to largely test `BufferedInputStream` ...



--
This message was sent by Atlassian Jira
(v8.20.10#820010)