You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/11/03 23:21:55 UTC

Review Request: Cleaner data size strings in webui.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7856/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Vinod Kone.


Description
-------

Displays B, KB, MB, GB, TB as appropriate. Previously we were just displaying GB everywhere.
This reads nicely for humans. 


Diffs
-----

  src/webui/master/static/app.js b4a07c040822b03a2a2732a2a78574a7ee8deae1 
  src/webui/master/static/framework.html a0a5b7752b4b6d3db42f8ce16b4025ba833dcb83 
  src/webui/master/static/frameworks.html 8ec67cc3a0125a6df03485c15d4c07e326edf8cc 
  src/webui/master/static/home.html bb446da66025563139c89c81509b4555355f25dc 
  src/webui/master/static/slave.html dfe39c824d4cf0584d8707f51fca3a9eacb712b5 
  src/webui/master/static/slave_executor.html 84502affe164412cf4d6c1af8801bde4b8e4f564 
  src/webui/master/static/slave_framework.html 5acdaad29e81e7ec327fc32bc1b860fb6eaccc60 
  src/webui/master/static/slaves.html b7214ab2e0a3c5f32bcf6c95982cd2fcde078c29 

Diff: https://reviews.apache.org/r/7856/diff/


Testing
-------

Manually with local runs.


Thanks,

Ben Mahler

Re: Review Request: Cleaner data size strings in webui.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7856/#review13109
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Nov. 3, 2012, 10:21 p.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7856/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2012, 10:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Vinod Kone.
> 
> 
> Description
> -------
> 
> Displays B, KB, MB, GB, TB as appropriate. Previously we were just displaying GB everywhere.
> This reads nicely for humans. 
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/app.js b4a07c040822b03a2a2732a2a78574a7ee8deae1 
>   src/webui/master/static/framework.html a0a5b7752b4b6d3db42f8ce16b4025ba833dcb83 
>   src/webui/master/static/frameworks.html 8ec67cc3a0125a6df03485c15d4c07e326edf8cc 
>   src/webui/master/static/home.html bb446da66025563139c89c81509b4555355f25dc 
>   src/webui/master/static/slave.html dfe39c824d4cf0584d8707f51fca3a9eacb712b5 
>   src/webui/master/static/slave_executor.html 84502affe164412cf4d6c1af8801bde4b8e4f564 
>   src/webui/master/static/slave_framework.html 5acdaad29e81e7ec327fc32bc1b860fb6eaccc60 
>   src/webui/master/static/slaves.html b7214ab2e0a3c5f32bcf6c95982cd2fcde078c29 
> 
> Diff: https://reviews.apache.org/r/7856/diff/
> 
> 
> Testing
> -------
> 
> Manually with local runs.
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>