[GitHub] [kafka] kirktrue commented on a diff in pull request #14455: KAFKA-15507: Make AdminClient throw non-retriable exception for a new call while closing

["kirktrue (via GitHub)" <gi...@apache.org>]

kirktrue commented on code in PR #14455:
URL: https://github.com/apache/kafka/pull/14455#discussion_r1338802690


##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -1546,9 +1546,9 @@ void enqueue(Call call, long now) {
          */
         void call(Call call, long now) {
             if (hardShutdownTimeMs.get() != INVALID_SHUTDOWN_TIME) {
-                log.debug("The AdminClient is not accepting new calls. Timing out {}.", call);
+                log.debug("Cannot accept new call {} when AdminClient is closing.", call);
                 call.handleTimeoutFailure(time.milliseconds(),

Review Comment:
   That seems like a fine fix. Then we avoid the potentially confusing logging about timeouts that doesn't really apply. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org