You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/12 15:10:43 UTC

[GitHub] [incubator-nuttx] jarivanewijk opened a new pull request #556: NXP S32K1XX EVB boards - clock config cleanup

jarivanewijk opened a new pull request #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556
 
 
   This is the second PR with changes to the S32K clock configuration. This one cleans up the (peripheral) clock configuration of the S32K1XX EVB boards that are supported by NuttX.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598268199
 
 
   Oh boy !  hmmm let's eliminate some thing.....
   
   what does `which nxstyle` say?
   delete an rebuild it.
   
   Also you need to run checkpatch.sh (I know the name is misleading) passing it the commits. if all that does not work we should ping @xiaoxiang781216 and @liuguo09  on this
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598302945
 
 
   Trying to kick off CI

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598302158
 
 
   It's still generating errors, but if I read the log right, this is because a change in the first PR needs to be applied first. It should be okay.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 closed pull request #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
davids5 closed pull request #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598258565
 
 
   Okay... this one needs a little more work. I'll update it soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 merged pull request #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
davids5 merged pull request #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jarivanewijk removed a comment on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
jarivanewijk removed a comment on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598258565
 
 
   Okay... this one needs a little more work. I'll update it soon.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598293482
 
 
   Should be good now. I'll now start fixing the third PR as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jarivanewijk edited a comment on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
jarivanewijk edited a comment on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598260953
 
 
   It seems the CI is not consistent with what the nxstyle tool is telling me? The CI complains about "Wrong column position of comment right of code" but NXstyle says it passes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598260953
 
 
   It seems the CI is not consistent with what the nxstyle tool is telling me?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598387661
 
 
   As I suspected, after the first PR was merged the other two build just fine. I rebased both PRs onto master again. Thanks for sticking with me. Both this and #557 should be ready to merge now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
jarivanewijk commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598278582
 
 
   I am not sure what I have been doing wrong, but now I get the right output from both nxstyle and checkpatch.sh. I think it worked after a rebuild. But I didn't build it the first time before I rebased everything onto master. Anyway, probably a stupid mistake on my side.
   
   I'll update the branch soon. Shouldn't take too long.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] jarivanewijk opened a new pull request #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
jarivanewijk opened a new pull request #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556
 
 
   This is the second PR with changes to the S32K clock configuration. This one cleans up the (peripheral) clock configuration of the S32K1XX EVB boards that are supported by NuttX.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598304238
 
 
   @jarivanewijk - I think it is a real build failure: https://github.com/apache/incubator-nuttx/pull/556/checks?check_run_id=503740926#step:7:197

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-nuttx] davids5 commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup

Posted by GitBox <gi...@apache.org>.
davids5 commented on issue #556: NXP S32K1XX EVB boards - clock config cleanup
URL: https://github.com/apache/incubator-nuttx/pull/556#issuecomment-598308768
 
 
   @jarivanewijk  The ci failure is listed on the details there is a red X.
   
   ![image](https://user-images.githubusercontent.com/1945821/76547350-423ef080-644a-11ea-8910-e089e3a26e97.png)
   
   the PRs have to be able to come in without breaking master. I did not look at he changes in detail but you many have to restructure them to be atomtc OR get one in and rebase, then the next etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services