[GitHub] [spark] srowen commented on a change in pull request #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #24998: [SPARK-28202] [Core] [Test] Avoid noises of system props in SparkConfSuite
URL: https://github.com/apache/spark/pull/24998#discussion_r299044481
 
 

 ##########
 File path: core/src/test/scala/org/apache/spark/SparkConfSuite.scala
 ##########
 @@ -242,7 +242,8 @@ class SparkConfSuite extends SparkFunSuite with LocalSparkContext with ResetSyst
   }
 
   test("deprecated configs") {
-    val conf = new SparkConf()
+    // Set `loadDefaults` to be false, so avoid system props's noises.
 
 Review comment:
   I'd remove this comment, I'm not sure what the 'noise' is here. It's really a workaround for your env.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org