You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/02/16 02:07:46 UTC

[GitHub] [echarts] pissang edited a comment on pull request #16431: fix(line): using sampling with lttb, NaN point should not be filtered.

pissang edited a comment on pull request #16431:
URL: https://github.com/apache/echarts/pull/16431#issuecomment-1041016471


   I'm not sure but when I'm running visual regression test(which has roslution 830x750), the current behavior seems to having unexpected points in the null values.
   
   Also I think we can add the case from https://codepen.io/tmscer/pen/yLgGXbo directly.
   
   Before:
   ![image](https://user-images.githubusercontent.com/841551/154181894-d2186c0a-90d3-43ca-8175-d9387803dae1.png)
   
   After:
   ![image](https://user-images.githubusercontent.com/841551/154181914-bc354da0-c8e5-444a-89fe-2c7d0e21f263.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org