[GitHub] [shardingsphere] RaigorJiang commented on a change in pull request #13329: `drop sharding binding table rule` can specify table deletion

[GitBox <gi...@apache.org>]

RaigorJiang commented on a change in pull request #13329:
URL: https://github.com/apache/shardingsphere/pull/13329#discussion_r738919045



##########
File path: shardingsphere-test/shardingsphere-parser-test/src/main/java/org/apache/shardingsphere/test/sql/parser/parameterized/asserts/statement/distsql/rdl/drop/impl/DropShardingBindingTableRulesStatementAssert.java
##########
@@ -37,5 +42,11 @@
      * @param expected expected drop sharding binding table rule statement test case
      */
     public static void assertIs(final SQLCaseAssertContext assertContext, final DropShardingBindingTableRulesStatement actual, final DropShardingBindingTableRulesStatementTestCase expected) {
+        if (null == expected) {
+            assertNull(assertContext.getText("Actual statement should not exist."), actual);
+        } else {
+            assertNotNull(assertContext.getText("Actual statement should exist."), actual);
+            assertThat(assertContext.getText("readwrite splitting assertion error: "), actual.getBindingGroups(), is(expected.getRules()));

Review comment:
       error message wrong.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org