You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 16:08:07 UTC
[GitHub] [arrow] jorisvandenbossche opened a new pull request #9128: ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17
jorisvandenbossche opened a new pull request #9128:
URL: https://github.com/apache/arrow/pull/9128
(obviously still needs test, but already putting the fix I was testing locally in a draft PR)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9128: ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9128:
URL: https://github.com/apache/arrow/pull/9128#issuecomment-756228829
@wesm What do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #9128: ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #9128:
URL: https://github.com/apache/arrow/pull/9128#issuecomment-757939106
Added a tiny test, and added an R news bullet point. This should be ready then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #9128: ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #9128:
URL: https://github.com/apache/arrow/pull/9128#issuecomment-756225815
If it's a tiny file (can be less than 1 kB), can we then add it to the arrow repo itself? (historically, we have some files included in `pyarrow/tests/data`) Or do we try to avoid that entirely nowadays?
Can certainly look into adding a file to https://github.com/apache/arrow-testing as well
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9128: ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9128:
URL: https://github.com/apache/arrow/pull/9128#issuecomment-756421627
IMHO it's simpler to add a tiny file here than always having to worry with a git submodule. You could also defer it: @jonkeane is currently working on some backwards/forwards compat testing for parquet and feather files (#9118), so he could handle it there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #9128: ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on pull request #9128:
URL: https://github.com/apache/arrow/pull/9128#issuecomment-756420501
Would you mind adding a bullet to https://github.com/apache/arrow/blob/master/r/NEWS.md#bug-fixes since this was also reported in R (ARROW-10850)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #9128: ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #9128:
URL: https://github.com/apache/arrow/pull/9128
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #9128: ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #9128:
URL: https://github.com/apache/arrow/pull/9128#issuecomment-756223667
+1. Perhaps the test file should be added to https://github.com/apache/arrow-testing (not sure).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9128: ARROW-11163: [C++] Fix reading of compressed IPC/Feather files written with Arrow 0.17
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9128:
URL: https://github.com/apache/arrow/pull/9128#issuecomment-756211675
https://issues.apache.org/jira/browse/ARROW-11163
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org