You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/05/19 17:56:20 UTC

Review Request 34414: Every minute Ambari agent freezes for 10-15 while executing status commands

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34414/
-----------------------------------------------------------

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-11242
    https://issues.apache.org/jira/browse/AMBARI-11242


Repository: ambari


Description
-------

Status commands and security status commands pack is executed every minute and
takes ~15 seconds. While other tasks just hangs. This is very confusing for
the user.

The way optimize status commands is to execute them reflexively, since
creating the processes itself takes a lot of time (~50 processes are created
each pack).  
This reduces time of status commands to ~1.5seconds


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py b107e3f 
  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 3aa26a0 
  ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py PRE-CREATION 
  ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 2fb2ae5 
  ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py 4105500 
  ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py a3e4a39 
  ambari-common/src/main/python/resource_management/libraries/script/script.py 8de9247 

Diff: https://reviews.apache.org/r/34414/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 34414: Every minute Ambari agent freezes for 10-15 while executing status commands

Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34414/#review84323
-----------------------------------------------------------

Ship it!


Ship It!

- Dmitro Lisnichenko


On May 19, 2015, 3:56 p.m., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34414/
> -----------------------------------------------------------
> 
> (Updated May 19, 2015, 3:56 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-11242
>     https://issues.apache.org/jira/browse/AMBARI-11242
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Status commands and security status commands pack is executed every minute and
> takes ~15 seconds. While other tasks just hangs. This is very confusing for
> the user.
> 
> The way optimize status commands is to execute them reflexively, since
> creating the processes itself takes a lot of time (~50 processes are created
> each pack).  
> This reduces time of status commands to ~1.5seconds
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py b107e3f 
>   ambari-agent/src/main/python/ambari_agent/PythonExecutor.py 3aa26a0 
>   ambari-agent/src/main/python/ambari_agent/PythonReflectiveExecutor.py PRE-CREATION 
>   ambari-agent/src/test/python/ambari_agent/TestCustomServiceOrchestrator.py 2fb2ae5 
>   ambari-agent/src/test/python/ambari_agent/TestPythonExecutor.py 4105500 
>   ambari-common/src/main/python/resource_management/libraries/functions/check_process_status.py a3e4a39 
>   ambari-common/src/main/python/resource_management/libraries/script/script.py 8de9247 
> 
> Diff: https://reviews.apache.org/r/34414/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>