[jira] [Commented] (SOLR-14348) Split TestJsonFacets to multiple Test Classes

["Munendra S N (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-14348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17061787#comment-17061787 ] 

Munendra S N commented on SOLR-14348:
-------------------------------------

 [^SOLR-14348.patch] 
This patch splits {{TestJsonFacets}} into 3 {{TestJsonFacets}} (trimmed down), {{TestJsonFacetErrors}} and {{TestJsonRangeFacet}}.
* Range facet also covers distributed case now. To cover distributed case for errors, SOLR-14345 need to be resolved (without with it is difficult to verify error message)
[~mkhl] could you please review?

> Split TestJsonFacets to multiple Test Classes
> ---------------------------------------------
>
>                 Key: SOLR-14348
>                 URL: https://issues.apache.org/jira/browse/SOLR-14348
>             Project: Solr
>          Issue Type: Test
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Munendra S N
>            Priority: Major
>         Attachments: SOLR-14348.patch
>
>
> {{TestJsonFacets}} has parameterized testing. It runs each tests for each facet.method. There are error cases which doesn't actually need it. Also, facet.method is applicable only to term facets.
> There are few Range facet tests which are present and runs repeatedly without any change(facet.method as no effect). Also, splitting would help when we introduce facet.method to range which would be different to term facets



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org