You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/07/18 20:38:51 UTC
[GitHub] [maven] kwart opened a new pull request, #773: [MNG-7511] Ensure the degreeOfConcurrency is a positive number (3.9.x)
kwart opened a new pull request, #773:
URL: https://github.com/apache/maven/pull/773
Backports #767 into the `3.9.x`.
JIRA: https://issues.apache.org/jira/browse/MNG-7511
This PR ensures the `degreeOfConcurrency` is a positive number. It resolves issues when the computed value is `< 1`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] asfgit merged pull request #773: [MNG-7511] Ensure the degreeOfConcurrency is a positive number (3.9.x)
Posted by GitBox <gi...@apache.org>.
asfgit merged PR #773:
URL: https://github.com/apache/maven/pull/773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #773: [MNG-7511] Ensure the degreeOfConcurrency is a positive number (3.9.x)
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #773:
URL: https://github.com/apache/maven/pull/773#discussion_r923845420
##########
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##########
@@ -371,4 +375,20 @@ public void testVersionStringWithoutAnsi() throws Exception
assertEquals( MessageUtils.stripAnsiCodes( versionOut ), versionOut );
}
+ class ConcurrencyCalculator implements ThrowingRunnable
Review Comment:
Is this a technical requirement from JUnit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwart commented on a diff in pull request #773: [MNG-7511] Ensure the degreeOfConcurrency is a positive number (3.9.x)
Posted by GitBox <gi...@apache.org>.
kwart commented on code in PR #773:
URL: https://github.com/apache/maven/pull/773#discussion_r923854420
##########
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##########
@@ -371,4 +375,20 @@ public void testVersionStringWithoutAnsi() throws Exception
assertEquals( MessageUtils.stripAnsiCodes( versionOut ), versionOut );
}
+ class ConcurrencyCalculator implements ThrowingRunnable
Review Comment:
I guess so if we stick to Java 1.7 code level. It seems to be cleaner than anonymous classes used directly in the test method.
The signature of the assert method is: `<T extends Throwable> T assertThrows(Class<T>, ThrowingRunnable)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] kwart commented on pull request #773: [MNG-7511] Ensure the degreeOfConcurrency is a positive number (3.9.x)
Posted by GitBox <gi...@apache.org>.
kwart commented on PR #773:
URL: https://github.com/apache/maven/pull/773#issuecomment-1188622683
Thanks for the review, Michael.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a diff in pull request #773: [MNG-7511] Ensure the degreeOfConcurrency is a positive number (3.9.x)
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #773:
URL: https://github.com/apache/maven/pull/773#discussion_r923855612
##########
maven-embedder/src/test/java/org/apache/maven/cli/MavenCliTest.java:
##########
@@ -371,4 +375,20 @@ public void testVersionStringWithoutAnsi() throws Exception
assertEquals( MessageUtils.stripAnsiCodes( versionOut ), versionOut );
}
+ class ConcurrencyCalculator implements ThrowingRunnable
Review Comment:
That's fine although Maven 3.9 is Java 8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org