You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/06/23 11:26:35 UTC
[GitHub] [fineract] ezolnbl opened a new pull request #1103: FINERACT add release onhold interop transaction
ezolnbl opened a new pull request #1103:
URL: https://github.com/apache/fineract/pull/1103
## Description
Add release of already onhold amount from interoperation transaction.
- [ ] API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm has been updated with details of any API changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ezolnbl commented on pull request #1103: FINERACT add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
ezolnbl commented on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-648923135
this is very strange because I did not modify those files and I run spotlessCheck and Apply before I created the pull request
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] github-actions[bot] commented on pull request #1103: FINERACT add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-668305121
This pull request seems to be stale. Are you still planning to work on it? We will automatically close it in 30 days.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1103: FINERACT add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-648123525
Failed due to checkstyle errors, most probably you can fix them with
`./gradlew spotlessApply`
If not,
Maybe this helps: https://github.com/apache/fineract#checkstyle-and-spotless
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] edcable commented on pull request #1103: FINERACT-1116 add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
edcable commented on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-673592539
@conradsp Did you have time to review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1103: FINERACT add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-649549788
Oh I just understood what happened, you probably did not full the new changes(first), and used the older config for spotless. This made it make outdated changes causing the build to fail :(
THIS looks good now :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] conradsp merged pull request #1103: FINERACT-1116 add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
conradsp merged pull request #1103:
URL: https://github.com/apache/fineract/pull/1103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ezolnbl edited a comment on pull request #1103: FINERACT add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
ezolnbl edited a comment on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-648923135
this is very strange because I did not modify those files and I run spotlessCheck and Apply before I created the pull request, I will fix it manually
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] awasum commented on pull request #1103: FINERACT add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
awasum commented on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-653748956
> @ezolnbl we normally require an open FINERACT-xxx JIRA for Improvements or Bug Fixes.
>
> Would you be willing to create one at https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12335824 describing this?
@ezolnbl , will you like to address this feedback? cc @conradsp will you like to review this? @marta-jankovics ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] ezolnbl commented on pull request #1103: FINERACT-1116 add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
ezolnbl commented on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-673077570
>
>
> @ezolnbl we normally require an open FINERACT-xxx JIRA for Improvements or Bug Fixes.
>
> Would you be willing to create one at https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12335824 describing this?
Created ticket: https://issues.apache.org/jira/browse/FINERACT-1116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar edited a comment on pull request #1103: FINERACT add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
thesmallstar edited a comment on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-649549788
Oh I just understood what happened, you probably did not pull the new changes(first), and used the older config for spotless. This made it make outdated changes causing the build to fail :(
THIS looks good now :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] edcable commented on pull request #1103: FINERACT-1116 add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
edcable commented on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-673150419
Thanks @ezolnbl.
@vorburger @ptuomola @awasum Zoltan created a ticket referencing this PR and also addressed the merge conflict. It should be ready for review now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1103: FINERACT add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#issuecomment-650115369
@ezolnbl we normally require an open FINERACT-xxx JIRA for Improvements or Bug Fixes.
Would you be willing to create one at https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12335824 describing this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] conradsp commented on a change in pull request #1103: FINERACT-1116 add release onhold interop transaction
Posted by GitBox <gi...@apache.org>.
conradsp commented on a change in pull request #1103:
URL: https://github.com/apache/fineract/pull/1103#discussion_r470126144
##########
File path: fineract-provider/src/main/resources/sql/migrations/core_db/V352__interop_init.sql
##########
@@ -60,6 +60,9 @@ VALUES ('interop', 'READ_INTERTRANSFER', 'INTERTRANSFER', 'READ', 0);
INSERT INTO m_permission (`grouping`, code, entity_name, action_name, can_maker_checker)
VALUES ('interop', 'PREPARE_INTERTRANSFER', 'INTERTRANSFER', 'PREPARE', 0);
+INSERT INTO m_permission (grouping, code, entity_name, action_name, can_maker_checker)
Review comment:
Can you insert ` for consistency
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org