You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "MelodyShen (via GitHub)" <gi...@apache.org> on 2024/04/12 17:21:54 UTC
[PR] Revert "Tune maximum thread count for streaming dataflow worker executor dynamically. [beam]
MelodyShen opened a new pull request, #30952:
URL: https://github.com/apache/beam/pull/30952
This reverts commit d4990744cda3afe052422f5ae19ba17e0145218f.
Performance regression was detected. The potential reason might be that we added additional lock on the metrics.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Tune maximum thread count for streaming dataflow worker executor dynamically. [beam]
Posted by "MelodyShen (via GitHub)" <gi...@apache.org>.
MelodyShen commented on PR #30952:
URL: https://github.com/apache/beam/pull/30952#issuecomment-2052178600
Hi @damccorm @tudorm here is the pr to revert the https://github.com/apache/beam/pull/30439 that caused performance regression. Would you mind taking a look? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Tune maximum thread count for streaming dataflow worker executor dynamically. [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #30952:
URL: https://github.com/apache/beam/pull/30952#issuecomment-2052231920
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @tvalentyn added as fallback since no labels match configuration
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Tune maximum thread count for streaming dataflow worker executor dynamically. [beam]
Posted by "MelodyShen (via GitHub)" <gi...@apache.org>.
MelodyShen closed pull request #30952: Revert "Tune maximum thread count for streaming dataflow worker executor dynamically.
URL: https://github.com/apache/beam/pull/30952
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Tune maximum thread count for streaming dataflow worker executor dynamically. [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #30952:
URL: https://github.com/apache/beam/pull/30952#issuecomment-2052413019
do you need the revert to be *merged* in order to test performance change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Revert "Tune maximum thread count for streaming dataflow worker executor dynamically. [beam]
Posted by "MelodyShen (via GitHub)" <gi...@apache.org>.
MelodyShen commented on PR #30952:
URL: https://github.com/apache/beam/pull/30952#issuecomment-2052472089
> do you need the revert to be _merged_ in order to test performance change?
We plan to create an import cl and let the performance tests run against head during the weekends. And laster merge the pr if this change causes the regression. It seems the performance went back to normal currently so we are still observing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org