You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "rkeen-siemens (via GitHub)" <gi...@apache.org> on 2023/03/31 22:32:45 UTC
[GitHub] [netbeans] rkeen-siemens opened a new pull request, #5757: #4818: Update string renderer to only escape undisplayable code points.
rkeen-siemens opened a new pull request, #5757:
URL: https://github.com/apache/netbeans/pull/5757
Text displayed in the property sheet is escaped if the target font does not have a glyph for some of the characters. The existing implementation escapes some Unicode characters even if the target font can display them. This is due to the reliance on `Font.canDisplay(char)` which does not handle all Unicode characters.
The solution here is to update `RendererFactory.makeDisplayable` to iterate over the code points in the string rather than the characters. It then uses `Font.canDisplay(int)` to validate the glyph availability using the code point.
Unit tests are included to verify the existing behavior is maintained. All passed for the original code except `testDoesNotEscapeDisplayableCodePoint`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5757: #4818: Update string renderer to only escape undisplayable code points.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5757:
URL: https://github.com/apache/netbeans/pull/5757#issuecomment-1493157416
@rkeen-siemens could you add a screenshot to the PR? This would be linked from the release notes, screenshots are often helpful for visual changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5757: #4818: Update string renderer to only escape undisplayable code points.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5757:
URL: https://github.com/apache/netbeans/pull/5757#issuecomment-1494809700
@rkeen-siemens thanks again for the contribution, all green again -> merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5757: #4818: Update string renderer to only escape undisplayable code points.
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5757:
URL: https://github.com/apache/netbeans/pull/5757#issuecomment-1492882414
Thanks for the PR.
Locked and unlocked to trigger the right tests (it appears that the unapproved test run doesn't pick up the label addition).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #5757: #4818: Update string renderer to only escape undisplayable code points.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien merged PR #5757:
URL: https://github.com/apache/netbeans/pull/5757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] rkeen-siemens commented on pull request #5757: #4818: Update string renderer to only escape undisplayable code points.
Posted by "rkeen-siemens (via GitHub)" <gi...@apache.org>.
rkeen-siemens commented on PR #5757:
URL: https://github.com/apache/netbeans/pull/5757#issuecomment-1494693516
> could you add a screenshot to the PR
Added before and after views for edit and view mode
> please update the email address on the commit
Updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #5757: #4818: Update string renderer to only escape undisplayable code points.
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #5757:
URL: https://github.com/apache/netbeans/pull/5757#issuecomment-1493072395
> it appears that the unapproved test run doesn't pick up the label addition at approval
@neilcsmith-net yes this is super annoying. I usually remove the not-approved workflow run from [here](https://github.com/apache/netbeans/actions) first, then start a new one with the lock trick. This is also mentioned as last point of the "important" section on the [wiki](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists