You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/05/09 11:44:45 UTC
[kudu-CR] [docs] Update macOS build docs
Hello Alexey Serbin, Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10356
to review the following change.
Change subject: [docs] Update macOS build docs
......................................................................
[docs] Update macOS build docs
* tapping homebrew/dupes is unnecessary now as it's now deprecated and
all formulae have been migrated to homebrew-core or deleted
* Apple deprecated OpenSSL so the openssl is keg-only now, meaning
pkg-config won't find it by default. "brew info openssl" warns about
this and suggests exporting PKG_CONFIG_PATH in .bash_profile, but some
people (like me) tend to not read this and blame the Kudu or the
thirdparty build for the weird errors.
Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
---
M docs/installation.adoc
1 file changed, 36 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/10356/1
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] [docs] Update macOS build docs
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 11 May 2018 16:37:14 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update macOS build docs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 2:
> > Patch Set 2:
> >
> > > > Patch Set 2:
> > > >
> > > > Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c
> ?
> > >
> > > probably less relevant than the original patch set, but I
> believe
> > > it could still fail, at least I managed to get this failure
> even
> > > without the check_openssl in preflight before adding
> > > PKG_CONFIG_PATH to my .bash_profile. I'm not completely sure
> how
> > > that happened though.
> >
> > If you use preflight and your openssl instaled via HomeBrew, then
> I would expect it to fail regardless of PKG_CONFIG_PATH in
> .bash_profile b prior 60c8e30 changelist.
> >
> > However, I don't think this is relevant after 60c8e30. I would
> prefer to keep less details in the docs if the things are already
> automated.
>
> +1. The dupes removal is still relevant.
Yep, I also think it's worth removing homebrew/dupes; that makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 10 May 2018 20:00:54 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update macOS build docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 2:
> Patch Set 2:
>
> > Patch Set 2:
> >
> > > > Patch Set 2:
> > > >
> > > > Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ?
> > >
> > > probably less relevant than the original patch set, but I believe
> > > it could still fail, at least I managed to get this failure even
> > > without the check_openssl in preflight before adding
> > > PKG_CONFIG_PATH to my .bash_profile. I'm not completely sure how
> > > that happened though.
> >
> > If you use preflight and your openssl instaled via HomeBrew, then I would expect it to fail regardless of PKG_CONFIG_PATH in .bash_profile b prior 60c8e30 changelist.
> >
> > However, I don't think this is relevant after 60c8e30. I would prefer to keep less details in the docs if the things are already automated.
>
> I ran into this first when I was trying to build 1.7.1-RC1 which is before check_openssl() was added to preflight, so I thought it could still fail.
>
> Upon further inspection I can see why it failed on 1.7.1-RC1, diff 1.7.1-RC1..HEAD reveals this change in build-thirdparty.sh:
>
> - OPENSSL_CFLAGS=$(pkg-config --cflags openssl)
> - if [ -z $OPENSSL_CFLAGS ]; then
> + if ! OPENSSL_CFLAGS=$(pkg-config --cflags openssl); then
>
> This pretty much rules out running into this on since 9f6b7f1682, so people can run into this only if building older branches.
>
> I'll remove this warning from the patch and backport KUDU-2346 (9f6b7f1682) to 1.7.x. Should I backport it to any other branches?
sorry, didn't check the formatting before posting, this is the actual diff:
- OPENSSL_CFLAGS=$(pkg-config --cflags openssl)
- if [ -z $OPENSSL_CFLAGS ]; then
+ if ! OPENSSL_CFLAGS=$(pkg-config --cflags openssl); then
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 11 May 2018 16:15:12 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update macOS build docs
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
[docs] Update macOS build docs
* tapping homebrew/dupes is unnecessary now as it's now deprecated and
all formulae have been migrated to homebrew-core or deleted
Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Reviewed-on: http://gerrit.cloudera.org:8080/10356
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Dan Burkert <da...@apache.org>
---
M docs/installation.adoc
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Dan Burkert: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Update macOS build docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 2:
> Patch Set 2:
>
> Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ?
probably less relevant than the original patch set, but I believe it could still fail, at least I managed to get this failure even without the check_openssl in preflight before adding PKG_CONFIG_PATH to my .bash_profile. I'm not completely sure how that happened though.
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 09 May 2018 17:45:35 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update macOS build docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10356
to look at the new patch set (#3).
Change subject: [docs] Update macOS build docs
......................................................................
[docs] Update macOS build docs
* tapping homebrew/dupes is unnecessary now as it's now deprecated and
all formulae have been migrated to homebrew-core or deleted
Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
---
M docs/installation.adoc
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/10356/3
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Update macOS build docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 2:
> Patch Set 2:
>
> > > Patch Set 2:
> > >
> > > Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ?
> >
> > probably less relevant than the original patch set, but I believe
> > it could still fail, at least I managed to get this failure even
> > without the check_openssl in preflight before adding
> > PKG_CONFIG_PATH to my .bash_profile. I'm not completely sure how
> > that happened though.
>
> If you use preflight and your openssl instaled via HomeBrew, then I would expect it to fail regardless of PKG_CONFIG_PATH in .bash_profile b prior 60c8e30 changelist.
>
> However, I don't think this is relevant after 60c8e30. I would prefer to keep less details in the docs if the things are already automated.
I ran into this first when I was trying to build 1.7.1-RC1 which is before check_openssl() was added to preflight, so I thought it could still fail.
Upon further inspection I can see why it failed on 1.7.1-RC1, diff 1.7.1-RC1..HEAD reveals this change in build-thirdparty.sh:
- OPENSSL_CFLAGS=$(pkg-config --cflags openssl)
- if [ -z $OPENSSL_CFLAGS ]; then
+ if ! OPENSSL_CFLAGS=$(pkg-config --cflags openssl); then
This pretty much rules out running into this on since 9f6b7f1682, so people can run into this only if building older branches.
I'll remove this warning from the patch and backport KUDU-2346 (9f6b7f1682) to 1.7.x. Should I backport it to any other branches?
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 11 May 2018 16:13:52 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update macOS build docs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 2:
Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ?
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 09 May 2018 17:43:23 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update macOS build docs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 2:
> > Patch Set 2:
> >
> > Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ?
>
> probably less relevant than the original patch set, but I believe
> it could still fail, at least I managed to get this failure even
> without the check_openssl in preflight before adding
> PKG_CONFIG_PATH to my .bash_profile. I'm not completely sure how
> that happened though.
If you use preflight and your openssl instaled via HomeBrew, then I would expect it to fail regardless of PKG_CONFIG_PATH in .bash_profile b prior 60c8e30 changelist.
However, I don't think this is relevant after 60c8e30. I would prefer to keep less details in the docs if the things are already automated.
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 10 May 2018 19:41:36 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update macOS build docs
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 3: Verified+1
unrelated flake
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 11 May 2018 17:04:18 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update macOS build docs
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 2:
> Patch Set 2:
>
> > > Patch Set 2:
> > >
> > > Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ?
> >
> > probably less relevant than the original patch set, but I believe
> > it could still fail, at least I managed to get this failure even
> > without the check_openssl in preflight before adding
> > PKG_CONFIG_PATH to my .bash_profile. I'm not completely sure how
> > that happened though.
>
> If you use preflight and your openssl instaled via HomeBrew, then I would expect it to fail regardless of PKG_CONFIG_PATH in .bash_profile b prior 60c8e30 changelist.
>
> However, I don't think this is relevant after 60c8e30. I would prefer to keep less details in the docs if the things are already automated.
+1. The dupes removal is still relevant.
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 10 May 2018 19:43:23 +0000
Gerrit-HasComments: No
[kudu-CR] [docs] Update macOS build docs
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Dan Burkert, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10356
to look at the new patch set (#2).
Change subject: [docs] Update macOS build docs
......................................................................
[docs] Update macOS build docs
* tapping homebrew/dupes is unnecessary now as it's now deprecated and
all formulae have been migrated to homebrew-core or deleted
* Apple deprecated OpenSSL so the openssl is keg-only now, meaning
pkg-config won't find it by default. "brew info openssl" warns about
this and suggests exporting PKG_CONFIG_PATH in .bash_profile, but some
people (like me) tend to not read this and blame the Kudu or the
thirdparty build for the weird errors.
Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
---
M docs/installation.adoc
1 file changed, 35 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/56/10356/2
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [docs] Update macOS build docs
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10356 )
Change subject: [docs] Update macOS build docs
......................................................................
Patch Set 2:
(2 comments)
> Patch Set 2:
>
> > Patch Set 2:
> >
> > Is this relevant after 60c8e305bef9ace8688aabbf18e2f500e8d9135c ?
>
> probably less relevant than the original patch set, but I believe it could still fail, at least I managed to get this failure even without the check_openssl in preflight before adding PKG_CONFIG_PATH to my .bash_profile. I'm not completely sure how that happened though.
FWIW I haven't had to set PKG_CONFIG_PATH to get the build to work
http://gerrit.cloudera.org:8080/#/c/10356/2/docs/installation.adoc
File docs/installation.adoc:
http://gerrit.cloudera.org:8080/#/c/10356/2/docs/installation.adoc@615
PS2, Line 615: libraris
nit: libraries
http://gerrit.cloudera.org:8080/#/c/10356/2/docs/installation.adoc@617
PS2, Line 617: /usr/local
surround with back ticks
--
To view, visit http://gerrit.cloudera.org:8080/10356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2a8aa7f58b7401115f36f42634d80b4d64e9794
Gerrit-Change-Number: 10356
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Thu, 10 May 2018 18:21:11 +0000
Gerrit-HasComments: Yes