You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Nikolay Khitrin (JIRA)" <ji...@apache.org> on 2019/02/07 14:41:00 UTC
[jira] [Updated] (LUCENE-8683) Synchronize JavaCC tasks with actual
Java code
[ https://issues.apache.org/jira/browse/LUCENE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nikolay Khitrin updated LUCENE-8683:
------------------------------------
Attachment: LUCENE-8683.patch
> Synchronize JavaCC tasks with actual Java code
> ----------------------------------------------
>
> Key: LUCENE-8683
> URL: https://issues.apache.org/jira/browse/LUCENE-8683
> Project: Lucene - Core
> Issue Type: Task
> Components: general/build
> Affects Versions: master (9.0), 8.x
> Reporter: Nikolay Khitrin
> Priority: Major
> Attachments: LUCENE-8683.patch
>
>
> h5. Changes list:
> # Apply SOLR-11662 changes back to Solr QueryParser.jj
> # Move jj_3R_7 method in Solr QueryParser.java back to generated position after SOLR-9185 merge.
> # Incorporate deprecated methods removal in CharStream by SOLR-8764 to ant build via regexps.
> # Incorporate unused imports removal by LUCENE-7319 to ant build via regexps.
> # Remove unused import from Lucene surround/parser/QueryParser.jj
> # Move license header from PARSER_BEGIN/PARSER_END block in Lucene flexible/standard/parser/StandardSyntaxParser.jj
> # Update JavaCC's OriginalChecksum lines to actual for Lucene flexible standard parser utility classes.
> h5. Cumulative effect of this patch:
> * Actual query parsing code remains unchanged.
> * ant javacc (both lucene/queryparser and solr/core) now left source tree intact.
> h5. Final thoughts:
> * I’m not very happy with this tricky regexp replacements, maybe we should pick some special tool for sources postprocessing.
> * It will be great to develop a special precommit task to ensure metasource and source consistency.
> Patch removing Lucene CharStream deprecated methods extracted to sub-task for master branch only.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org